ML-KEM: Validate expanded decapsulation key hash #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGibson1
force-pushed
the
ml-kem/validate-expanded-decapsulation-key-hash
branch
from
661d9b0 to
0beedc5
Compare
Member
|
@MGibson1 can you merge/rebase? |
FIPS 203 section 3.3 "Destruction of intermediate values" specifies that both parts of the seed (z, d) should be treated in the same manner at the decapsulation key itself, which is to zeroize.
MGibson1
force-pushed
the
ml-kem/validate-expanded-decapsulation-key-hash
branch
from
0beedc5 to
c6c2cd9
Compare
FIPS 203 section 7.2 requires verifying the provided encapsulation key hash against the encapsulation key included in the serialized format.
MGibson1
force-pushed
the
ml-kem/validate-expanded-decapsulation-key-hash
branch
from
c6c2cd9 to
30faa18
Compare
Contributor
Author
|
Done. Sorry about that, I thought I'd isolated those two PRs but it looks like I mistakenly included both changes in this one. |
tarcieri
approved these changes
Jan 30, 2026
tarcieri
added a commit
that referenced
this pull request
Jan 30, 2026
After merging #207 we need to handle errors from invalid hashes
Merged
tarcieri
added a commit
that referenced
this pull request
Jan 30, 2026
After merging #207 we need to handle errors from invalid hashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIPS 203 section 7.3 Decapsulation input check
where$H$ is sha3-256.
Tests are added of this hash verification and todo comments removed.