Symbol for _destination property#78
Merged
RubenVerborgh merged 1 commit intoRubenVerborgh:mainfrom Jul 31, 2022
jacoscaz:destination-symbol
Merged
Symbol for _destination property#78RubenVerborgh merged 1 commit intoRubenVerborgh:mainfrom jacoscaz:destination-symbol
RubenVerborgh merged 1 commit intoRubenVerborgh:mainfrom
jacoscaz:destination-symbol
Conversation
Merged
Owner
|
Thanks, @jacoscaz, I'm happy to take it from here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR complements #63 (which should be merged first) by renaming the
_destinationproperty to a dedicatedSymbol, guaranteed to be unique, so that we can never trigger property collisions when setting_destinationon externally-provided source objects for whichisAsyncReadable(source) === trueatAsyncIterator/asynciterator.ts
Lines 2030 to 2043 in 159ed2b