Skip to content

feat: change default workspace filter to "All" in task history view #10685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roomote wants to merge 1 commit into from
+10 −9
Closed

feat: change default workspace filter to "All" in task history view #10685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions webview-ui/src/components/history/__tests__/useTaskSearch.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,27 +63,28 @@ describe("useTaskSearch", () => {
it("returns all tasks by default", () => {
const { result } = renderHook(() => useTaskSearch())

expect(result.current.tasks).toHaveLength(2) // Only tasks from current workspace
expect(result.current.tasks).toHaveLength(3) // All tasks from all workspaces
expect(result.current.tasks[0].id).toBe("task-2") // Newest first
expect(result.current.tasks[1].id).toBe("task-1")
expect(result.current.tasks[2].id).toBe("task-3")
})

it("filters tasks by current workspace by default", () => {
it("shows all workspaces by default", () => {
const { result } = renderHook(() => useTaskSearch())

expect(result.current.tasks).toHaveLength(2)
expect(result.current.tasks.every((task) => task.workspace === "/workspace/project1")).toBe(true)
expect(result.current.tasks).toHaveLength(3)
expect(result.current.showAllWorkspaces).toBe(true)
})

it("shows all workspaces when showAllWorkspaces is true", () => {
it("filters tasks by current workspace when showAllWorkspaces is false", () => {
const { result } = renderHook(() => useTaskSearch())

act(() => {
result.current.setShowAllWorkspaces(true)
result.current.setShowAllWorkspaces(false)
})

expect(result.current.tasks).toHaveLength(3)
expect(result.current.showAllWorkspaces).toBe(true)
expect(result.current.tasks).toHaveLength(2)
expect(result.current.tasks.every((task) => task.workspace === "/workspace/project1")).toBe(true)
})

it("sorts by newest by default", () => {
Expand Down
2 changes: 1 addition & 1 deletion webview-ui/src/components/history/useTaskSearch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const useTaskSearch = () => {
const [searchQuery, setSearchQuery] = useState("")
const [sortOption, setSortOption] = useState<SortOption>("newest")
const [lastNonRelevantSort, setLastNonRelevantSort] = useState<SortOption | null>("newest")
const [showAllWorkspaces, setShowAllWorkspaces] = useState(false)
const [showAllWorkspaces, setShowAllWorkspaces] = useState(true)

useEffect(() => {
if (searchQuery && sortOption !== "mostRelevant" && !lastNonRelevantSort) {
Expand Down
Loading