fix: orchestrator mode forwards environment settings to subtasks #10682
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #10681
Description
This PR attempts to address Issue #10681 where conda/venv environment settings are not being forwarded from the Orchestrator mode to subtasks (like "ask" or "code" modes).
The Problem:
When a user specifies a Python environment path (e.g., conda or virtualenv) in their prompt to the Orchestrator, child tasks default to using the system
pythoncommand instead of the user-specified path.The Solution:
Updated the Orchestrator mode's
customInstructionsinpackages/types/src/mode.tsto explicitly include environment/runtime settings as critical context that must always be forwarded to subtasks.Added a new bullet point to the list of things that "must include" when delegating subtasks:
This is a simple, low-risk change that modifies only prompt text and guides the LLM to do the right thing naturally.
Test Procedure
packages/typespass (npx vitest run)tsc --noEmit)Pre-Submission Checklist
Documentation Updates
Additional Notes
This is a prompt-only change that applies to all types of environment settings, not just Python. Feedback and guidance are welcome!
Important
Updates
mode.tsto forward environment settings from Orchestrator mode to subtasks, ensuring user-specified paths and variables are included.customInstructionsinmode.tsto include user-specified environment/runtime settings for subtasks in Orchestrator mode.packages/typespass.This description was created by
for 33b03dc. You can customize this summary. It will automatically update as commits are pushed.