Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jan 13, 2026

Related GitHub Issue

Closes: #10681

Description

This PR attempts to address Issue #10681 where conda/venv environment settings are not being forwarded from the Orchestrator mode to subtasks (like "ask" or "code" modes).

The Problem:
When a user specifies a Python environment path (e.g., conda or virtualenv) in their prompt to the Orchestrator, child tasks default to using the system python command instead of the user-specified path.

The Solution:
Updated the Orchestrator mode's customInstructions in packages/types/src/mode.ts to explicitly include environment/runtime settings as critical context that must always be forwarded to subtasks.

Added a new bullet point to the list of things that "must include" when delegating subtasks:

  • Any environment or runtime settings specified by the user, including but not limited to: Python interpreter paths (e.g., conda environments, virtualenvs), working directory requirements, environment variables, and tool/CLI specific paths or configurations.

This is a simple, low-risk change that modifies only prompt text and guides the LLM to do the right thing naturally.

Test Procedure

  1. All existing tests in packages/types pass (npx vitest run)
  2. TypeScript compilation passes (tsc --noEmit)
  3. Lint checks pass
  4. Manual verification scenario: Start Orchestrator mode and instruct it to use a specific Python environment path, then observe that when delegating to "ask" or "code" mode, the environment path is included in the subtask instructions.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: Tests pass and the change is prompt-only, not requiring new code tests.
  • Documentation Impact: No documentation updates are required.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

  • No documentation updates are required.

Additional Notes

This is a prompt-only change that applies to all types of environment settings, not just Python. Feedback and guidance are welcome!


Important

Updates mode.ts to forward environment settings from Orchestrator mode to subtasks, ensuring user-specified paths and variables are included.

  • Behavior:
    • Updates customInstructions in mode.ts to include user-specified environment/runtime settings for subtasks in Orchestrator mode.
    • Ensures Python interpreter paths, working directory, environment variables, and tool/CLI paths are forwarded to subtasks.
  • Testing:
    • All existing tests in packages/types pass.
    • TypeScript compilation passes.
    • Manual verification confirms environment settings are included in subtask instructions.

This description was created by Ellipsis for 33b03dc. You can customize this summary. It will automatically update as commits are pushed.

@roomote
Copy link
Contributor Author

roomote bot commented Jan 13, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

This is a clean, low-risk change that adds explicit guidance for forwarding environment/runtime settings to subtasks. The instruction is well-placed, clear, and provides useful examples.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Conda or venv Environment not synced across roles when starting as the orchestrator

2 participants