Skip to content

Conversation

@ThanhNguyxn
Copy link

@ThanhNguyxn ThanhNguyxn commented Jan 13, 2026

Summary

Fixes #10657

The checkpoint initialization warning was using a hardcoded 5-second value (WARNING_THRESHOLD_MS / 1000) for the timeout parameter in the warning message, regardless of the user's actual configured checkpoint timeout.

This PR updates the code to use task.checkpointTimeout for the warning message parameter, ensuring the message correctly reflects the configured timeout (e.g., "taking longer than 15 seconds...").

Changes

  • Modified src/core/checkpoints/index.ts: Pass task.checkpointTimeout instead of hardcoded 5s to sendCheckpointInitWarn.
  • Updated src/core/checkpoints/__tests__/checkpoint.test.ts: Updated test case to verify that the warning message receives the configured timeout value.

Testing

  1. Verified closely with the existing test suite.
  2. The should send warning message when initialization is slow test case now explicitly checks for matching task.checkpointTimeout.

Important

Fixes hardcoded timeout in checkpoint warning message to use task.checkpointTimeout in index.ts.

  • Behavior:
    • sendCheckpointInitWarn in index.ts now uses task.checkpointTimeout instead of a hardcoded 5s for warning messages.
    • Updates warning message to reflect configured timeout (e.g., "taking longer than 15 seconds...").
  • Testing:
    • Updated test in checkpoint.test.ts to verify warning message uses task.checkpointTimeout.
    • Test case should send warning message when initialization is slow checks for correct timeout value in warning message.

This description was created by Ellipsis for ff9bc99. You can customize this summary. It will automatically update as commits are pushed.

Fixes RooCodeInc#10657

Previously the checkpoint wait warning used a hardcoded 5s value (WARNING_THRESHOLD_MS / 1000)
even though the elapsed check correctly used the constant.
This resulted in the warning always saying 'taking longer than 5 seconds' regardless of the actual timeout setting.
Now it uses task.checkpointTimeout for the message parameter.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jan 13, 2026
@roomote
Copy link
Contributor

roomote bot commented Jan 13, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found. The fix correctly uses task.checkpointTimeout instead of the hardcoded 5-second value for the warning message, making it consistent with how INIT_TIMEOUT already handles this.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Checkpoint init warning shows wrong timeout

1 participant