Add web search functionality similar to Cline #10676
Conversation
- Add web_search tool that works for all models - Created tool class (WebSearchTool.ts) with BaseTool pattern - Added native tool definition for OpenAI-compatible APIs - Added XML description for non-native protocols - Updated tool types, display names, and groups - Integrated with i18n system for translations - Added comprehensive test coverage (10 tests) - Mock implementation demonstrates functionality - Can be replaced with real search API integration (Brave, Google, Bing, DuckDuckGo) - Alternatively, users can use Perplexity MCP server for real search Implements COM-464
Re-reviewed domain filtering changes. Implementation looks correct. The existing blocking issue remains unresolved.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
|
@roomote does not need any XML since we're sunsetting that. |
Removed XML tool description for web_search since XML is being sunset. All local checks passed. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| export const webSearchTool = new WebSearchTool() |
There was a problem hiding this comment.
Missing tool registration in presentAssistantMessage.ts: The webSearchTool is exported here but never imported or registered in the tool dispatcher. The switch statement in presentAssistantMessage.ts (lines 872-1190) lacks a case "web_search": handler, and the toolDescription function also needs a case for this tool. When the model calls web_search, it will fall through to the default: case and fail with "Unknown tool 'web_search'. This tool does not exist."
Required changes to src/core/assistant-message/presentAssistantMessage.ts:
- Add import:
import { webSearchTool } from "../tools/WebSearchTool" - Add case in
toolDescriptionfunction:case "web_search": return \[${block.name} for '${block.params.query}']`` - Add case in switch statement to call
webSearchTool.handle()
Fix it with Roo Code or mention @roomote and request a fix.
- Add allowed_domains and blocked_domains parameters to WebSearchParams - Implement domain filtering logic in WebSearchTool - Add domain parameter handling in NativeToolCallParser - Update tool prompt with domain filtering documentation - Add parseDomainsArray helper function - Enhance handlePartial to show domain filters in UI This brings full parity with Cline web search domain filtering capabilities.
Add web search functionality to Roo Code, pulling over the approach used in Cline.
Summary
This PR implements a web_search tool that provides web search capabilities to all models:
Implementation Details
The current implementation uses mock search results for demonstration purposes. This allows the tool to work without requiring additional API keys or setup. In production, this can be replaced with real search API integration:
Alternatively, users can use the existing Perplexity MCP server for real web search capabilities.
Testing
View task on Roo Code Cloud
Important
Adds
WebSearchToolfor web search functionality with mock data, integrated into the system with tests and i18n support.WebSearchToolclass inWebSearchTool.tsfor web search functionality using mock data.web_searchtool intoNativeToolCallParser.tsandindex.ts.tools.jsonfor web search messages.WebSearchTool.spec.tswith 10 tests forWebSearchTool.tool.tsandtools.tsto includeweb_searchin tool names and groups.This description was created by
for ba6b76a. You can customize this summary. It will automatically update as commits are pushed.