Update API key references to SDK key and bump version to 1.0.1 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename MissingApiKeyException to MissingSdkKeyException - Rename InvalidApiKeyException to InvalidSdkKeyException - Update error messages to reference SDK key instead of API key - Update test names and imports accordingly - Bump version from 1.0.0 to 1.0.1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…adata - Remove importlib.metadata dependency which was looking up wrong package name - Add _get_version() helper that reads directly from sdk_reforge/VERSION file - This works in both installed and development environments - Fixes PackageNotFoundError when package metadata is unavailable 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add __version_cache module-level variable - Read VERSION file only once, cache result for subsequent calls - Improves performance by avoiding repeated file I/O 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MissingApiKeyExceptiontoMissingSdkKeyExceptionwith updated error messageInvalidApiKeyExceptiontoInvalidSdkKeyExceptionwith updated error messagepyproject.tomlandsdk_reforge/VERSIONimportlib.metadatadependency for version lookup_get_version()helper that reads fromsdk_reforge/VERSIONfile directlyThis change improves clarity by using "SDK key" consistently throughout the codebase, which better reflects the actual terminology used in the service.
The version lookup fix resolves
PackageNotFoundErrorissues when package metadata is unavailable (e.g., in development environments) and works consistently in both installed and development modes.Test plan
🤖 Generated with Claude Code