Skip to content

Reduce SSE logging verbosity and bump version to 1.0.3 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkebinger merged 3 commits into from
Oct 16, 2025
Merged

Reduce SSE logging verbosity and bump version to 1.0.3 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48e0ed4
Reduce SSE logging verbosity to avoid noise
jkebinger Oct 16, 2025
bde2b70
Bump version to 1.0.3
jkebinger Oct 16, 2025
d8d2cac
Reformat file
jkebinger Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion micronaut/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>com.reforge</groupId>
<artifactId>sdk-parent</artifactId>
<version>1.0.2</version>
<version>1.0.3</version>
</parent>

<artifactId>sdk-micronaut-extension</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<groupId>com.reforge</groupId>
<artifactId>sdk-parent</artifactId>

<version>1.0.2</version>
<version>1.0.3</version>
<packaging>pom</packaging>
<name>Reforge SDK Parent POM</name>
<description>Parent POM for Reforge SDK modules providing feature flags, configuration management, and A/B testing capabilities</description>
Expand Down
2 changes: 1 addition & 1 deletion sdk/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>com.reforge</groupId>
<artifactId>sdk-parent</artifactId>
<version>1.0.2</version>
<version>1.0.3</version>
</parent>

<artifactId>sdk</artifactId>
Expand Down
8 changes: 3 additions & 5 deletions sdk/src/main/java/com/reforge/sdk/internal/SseConfigStreamingSubscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,8 @@ public void onSubscribe(Flow.Subscription subscription) {
public void onNext(Event item) {
if (item instanceof CommentEvent) {
CommentEvent commentEvent = (CommentEvent) item;
LOG.info("Received comment event: {}", commentEvent);
}
if (item instanceof DataEvent) {
LOG.debug("Received comment event: {}", commentEvent);
} else if (item instanceof DataEvent) {
DataEvent dataEvent = (DataEvent) item;
try {
hasReceivedData.set(true);
Expand Down Expand Up @@ -142,7 +141,6 @@ public void onNext(Event item) {

@Override
public void onError(Throwable throwable) {
LOG.info("Unexpected error encountered", throwable);
if (Optional.ofNullable(throwable.getMessage()).orElse("").contains("GOAWAY")) {
LOG.debug("Got GOAWAY on SSE config stream, will restart connection.");
} else {
Expand All @@ -154,7 +152,7 @@ public void onError(Throwable throwable) {
@Override
public void onComplete() {
// this is called even on auth failure
LOG.info("Unexpected stream completion");
LOG.debug("Unexpected stream completion");
restartHandler.accept(getHasReceivedData());
}

Expand Down