Skip to content

Change Micronaut context attribute key to avoid collision with prefab-sdk #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkebinger merged 2 commits into from
Oct 15, 2025
Merged

Change Micronaut context attribute key to avoid collision with prefab-sdk #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f59c47c
Change Micronaut context attribute key to avoid collision with prefab…
jkebinger Oct 15, 2025
d024af7
Bumps version to 1.0.2
jkebinger Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion micronaut/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>com.reforge</groupId>
<artifactId>sdk-parent</artifactId>
<version>1.0.1</version>
<version>1.0.2</version>
</parent>

<artifactId>sdk-micronaut-extension</artifactId>
Expand Down
8 changes: 4 additions & 4 deletions micronaut/src/main/java/com/reforge/sdk/extensions/micronaut/ServerRequestContextStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
*/
public class ServerRequestContextStore implements ContextStore {

public static final String ATTRIBUTE_NAME = "prefab-contexts";
public static final String ATTRIBUTE_NAME = "reforge-sdk-contexts";

@Override
public void addContext(Context context) {
getPrefabContextSet()
getReforgeContextSet()
.ifPresentOrElse(
prefabContextSet -> prefabContextSet.addContext(context),
() -> setContext(context)
Expand Down Expand Up @@ -50,10 +50,10 @@ public Optional<ContextSetReadable> clearContext() {

@Override
public Optional<ContextSetReadable> getContext() {
return getPrefabContextSet().map(ContextSetReadable::readOnlyContextSetView);
return getReforgeContextSet().map(ContextSetReadable::readOnlyContextSetView);
}

private Optional<ContextSet> getPrefabContextSet() {
private Optional<ContextSet> getReforgeContextSet() {
return ServerRequestContext
.currentRequest()
.flatMap(objectHttpRequest ->
Expand Down
44 changes: 22 additions & 22 deletions ...aut/src/test/java/com/reforge/sdk/extensions/micronaut/ServerRequestContextStoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

class ServerRequestContextStoreTest {

ServerRequestContextStore prefabStateStore = new ServerRequestContextStore();
ServerRequestContextStore reforgeSdkContextStore = new ServerRequestContextStore();
Context userContext = Context.newBuilder("user").put("country", "us").build();
Context serverContext = Context.newBuilder("server").put("az", "2").build();

Expand All @@ -29,25 +29,25 @@ void beforeEach() {

@Test
void getContextReturnsEmpty() {
assertThat(prefabStateStore.getContext()).isEmpty();
assertThat(reforgeSdkContextStore.getContext()).isEmpty();
}

@Test
void setContextQuietlyDoesNothing() {
assertThat(prefabStateStore.setContext(userAndServerContextSet)).isEmpty();
assertThat(prefabStateStore.getContext()).isEmpty();
assertThat(reforgeSdkContextStore.setContext(userAndServerContextSet)).isEmpty();
assertThat(reforgeSdkContextStore.getContext()).isEmpty();
}

@Test
void addContextQuietlyDoesNothing() {
prefabStateStore.addContext(userContext);
assertThat(prefabStateStore.getContext()).isEmpty();
reforgeSdkContextStore.addContext(userContext);
assertThat(reforgeSdkContextStore.getContext()).isEmpty();
}

@Test
void clearContextQuietlyDoesNothing() {
assertThat(prefabStateStore.clearContext()).isEmpty();
assertThat(prefabStateStore.getContext()).isEmpty();
assertThat(reforgeSdkContextStore.clearContext()).isEmpty();
assertThat(reforgeSdkContextStore.getContext()).isEmpty();
}
}

Expand All @@ -63,18 +63,18 @@ void beforeEach() {

@Test
void getContextReturnsEmptyWhenNoContextSet() {
assertThat(prefabStateStore.getContext()).isEmpty();
assertThat(reforgeSdkContextStore.getContext()).isEmpty();
}

@Test
void setContextReturnsEmptyWhenNoContextSet() {
assertThat(prefabStateStore.setContext(userAndServerContextSet)).isEmpty();
assertThat(reforgeSdkContextStore.setContext(userAndServerContextSet)).isEmpty();
}

@Test
void addContextWhenEmptyUpdatesTheContext() {
prefabStateStore.addContext(userContext);
assertThat(prefabStateStore.getContext())
reforgeSdkContextStore.addContext(userContext);
assertThat(reforgeSdkContextStore.getContext())
.isPresent()
.get()
.usingRecursiveComparison()
Expand All @@ -83,8 +83,8 @@ void addContextWhenEmptyUpdatesTheContext() {

@Test
void clearReturnsEmpty() {
assertThat(prefabStateStore.clearContext()).isEmpty();
assertThat(prefabStateStore.getContext()).isEmpty();
assertThat(reforgeSdkContextStore.clearContext()).isEmpty();
assertThat(reforgeSdkContextStore.getContext()).isEmpty();
}

@Nested
Expand All @@ -98,12 +98,12 @@ class WithPreExistingContext {

@BeforeEach
void beforeEach() {
prefabStateStore.setContext(userAndServerContextSet);
reforgeSdkContextStore.setContext(userAndServerContextSet);
}

@Test
void getReturnsExpectedSet() {
assertThat(prefabStateStore.getContext())
assertThat(reforgeSdkContextStore.getContext())
.isPresent()
.get()
.usingRecursiveComparison()
Expand All @@ -112,22 +112,22 @@ void getReturnsExpectedSet() {

@Test
void clearWorksAsExpected() {
assertThat(prefabStateStore.clearContext())
assertThat(reforgeSdkContextStore.clearContext())
.isPresent()
.get()
.usingRecursiveComparison()
.isEqualTo(userAndServerContextSet);
assertThat(prefabStateStore.getContext()).isEmpty();
assertThat(reforgeSdkContextStore.getContext()).isEmpty();
}

@Test
void setWorksAsExpected() {
assertThat(prefabStateStore.setContext(userContext))
assertThat(reforgeSdkContextStore.setContext(userContext))
.isPresent()
.get()
.usingRecursiveComparison()
.isEqualTo(userAndServerContextSet);
assertThat(prefabStateStore.getContext())
assertThat(reforgeSdkContextStore.getContext())
.isPresent()
.get()
.usingRecursiveComparison()
Expand All @@ -136,8 +136,8 @@ void setWorksAsExpected() {

@Test
void addWorksAsExpected() {
prefabStateStore.addContext(newUserContext);
assertThat(prefabStateStore.getContext())
reforgeSdkContextStore.addContext(newUserContext);
assertThat(reforgeSdkContextStore.getContext())
.isPresent()
.get()
.usingRecursiveComparison()
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<groupId>com.reforge</groupId>
<artifactId>sdk-parent</artifactId>

<version>1.0.1</version>
<version>1.0.2</version>
<packaging>pom</packaging>
<name>Reforge SDK Parent POM</name>
<description>Parent POM for Reforge SDK modules providing feature flags, configuration management, and A/B testing capabilities</description>
Expand Down
2 changes: 1 addition & 1 deletion sdk/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>com.reforge</groupId>
<artifactId>sdk-parent</artifactId>
<version>1.0.1</version>
<version>1.0.2</version>
</parent>

<artifactId>sdk</artifactId>
Expand Down