Regression: Fix Android external dependencies #1084
Conversation
|
@jonnymind , After deliberation with the rest of the admin team, we have decided to drop official support for the Android Editor. I believe that it is much more important having working release templates that work with third party plugins and such. I am going to go ahead and take this out of draft, and merge it into our development branch so it can be included in our Beta for Redot LTS that we will be releasing in a couple of days. I am going to go ahead and close out #1093 since nobody can really get it to run on emulated or real hardware. |
Arctis-Fireblight
force-pushed
the
fix-android-plugin-deps
branch
from
d9421d6 to
3e29936
Compare
Arctis-Fireblight
force-pushed
the
fix-android-plugin-deps
branch
from
3e29936 to
86c454f
Compare
|
Understood. This is a wise decision indeed; different was if the contributors to the android editors could also provide a reliable way to test the rest of the android ecosystem as they submit their PR. |
The package org.godotengine is used both for the Java portion of the editor launched on Android and for the SDK exposed to third party tools and plugins. The recent change to rename the package to org.redotengine has broken all the binary (and source) dependencies of third party software. This changes reverts the package declarations to org.godotengine. However, this can't be merged as is: we first need to identify all the sources that constitute the editor engine on Android, and move those only to org.redotengine. That is necessary to be able to publish the Redot editor on android separately from Godot (and possibly sign applications built with it).
Arctis-Fireblight
force-pushed
the
fix-android-plugin-deps
branch
5 times, most recently
from
808fcf8 to
490ec66
Compare
Reverted the rest of the rebranding changes made to the android platform so that the package and API structure reflects stock Godot
Arctis-Fireblight
force-pushed
the
fix-android-plugin-deps
branch
from
490ec66 to
b135864
Compare
3 participants
NOT FOR MERGE.
The package org.godotengine is used both for the Java portion of the editor on Android and for the SDK exposed to third party tools and plugins.
The recent change to rename the package to org.redotengine has broken all the binary (and source) dependencies of third party software, changing the signature of the library they use to interact with the engine.
This PR reverts the package declarations to org.godotengine.
However, this can't be merged as is: we first need to identify all the sources that constitute the editor engine on Android, and move those only to org.redotengine. That is necessary to be able to publish the Redot editor on android separately from Godot (and possibly sign applications built with it).