Fixing thermo group corrections for cyclics#212
Merged
rwest merged 2 commits intoReactionMechanismGenerator:masterfrom Apr 18, 2014
Merged
Fixing thermo group corrections for cyclics#212rwest merged 2 commits intoReactionMechanismGenerator:masterfrom
rwest merged 2 commits intoReactionMechanismGenerator:masterfrom
Conversation
…t include gauche correcitons. Use overall ring correction instead of most destabilizing one for enthalpy. (We were using cyclopentane corrections for cyclopentene.) Now it is corrected. Don't include gauche corrections if the molecule is cyclic. (Still need to include them for parts of the molecule that aren't in the rings.. but we'll figure that out later.
rwest
added a commit
that referenced
this pull request
Apr 18, 2014
Fixing thermo group corrections for cyclics
Member
|
Looks Ok so I will merge as is, but would like some unit tests for this (that now pass but would have failed). Is it deterministic how we descend the tree? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should pull this in right away, as it fixes some of our problems such as cyclopentene using the cyclopentane group correction. Now it matches Java's implementation. However, gauche corrections are, like in Java, not completely implemented correctly. We will deal with this later.