-
Notifications
You must be signed in to change notification settings - Fork 1k
Unify messages for translation #7562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Generated via commit ae793fb Download link for the artifact containing the test results: ↓ atime-results.zip
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7562 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 87 87
Lines 16737 16739 +2
=======================================
+ Hits 16563 16565 +2
Misses 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| cols = colnamesInt(x, cols, check_dups=TRUE) | ||
| if (!length(cols)) | ||
| stopf("x is a list, 'cols' can not be 0-length") | ||
| stopf("x is a list, 'cols' cannot be 0-length.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| stopf("x is a list, 'cols' cannot be 0-length.") | |
| stopf("x is a list, 'cols' cannot be 0-length") |
since "most" error messages dont end with ., but NIT
ben-schwen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM.
Currently we also two different type of styles whether error message end with . or not. From a quick look, this mostly depends on the source file.

Gemini was used to identify the similar strings; I read over the analysis and applied its findings as appropriate.
This should help out the translation teams by minimizing duplicate work.
Details
Exact prompt to Gemini: