-
Notifications
You must be signed in to change notification settings - Fork 1k
allow showProgress=INTEGER to set progress bar update time #7259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7259 +/- ##
==========================================
+ Coverage 98.96% 98.99% +0.03%
==========================================
Files 87 87
Lines 16734 16729 -5
==========================================
+ Hits 16560 16561 +1
+ Misses 174 168 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Generated via commit ee671af Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
Thanks for the PR Ben. Is there a reason why the delay is integer rather than double/numeric? (which seems more natural for a time) |
I also thought about using |
MichaelChirico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge after the quick clean-ups requested. Thanks!
Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
…e#7259) * allow showProgress=INTEGER to set progress bar update time * add NEWS * cleanup merge * refine NEWS * make check more explicit * adjust docs * adjust nocov to what they really should cover * phrasing comment Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * Update NEWS.md Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * refine NEWS * update man * remove as.integer from signature * remove unnecessary brackets --------- Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>

Closes #6514