Checkbox to make teardrop doublesided#41
Open
Daniel-Steinberger wants to merge 3 commits intoRahix:mainfrom
Open
Checkbox to make teardrop doublesided#41Daniel-Steinberger wants to merge 3 commits intoRahix:mainfrom
Daniel-Steinberger wants to merge 3 commits intoRahix:mainfrom
Conversation
Add a new checkbox in the Teardrop creation dialog that when checked will add a teardrop shape to the hole counterbore, too.
Add a new checkbox in the Teardrop creation dialog that when checked makes the teardrop shape double sided. This is useful to give you more options for positioning your parts on the build plate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #38 (comment) this is a new checkbox to make the Teardrop double sided.
This is implemented by modifying the sketch. To reuse most of the code I extracted sketch generation and when requested this portion is called twice and some constraints are modified afterwards.
I did not however have time to also implement this for the roof, since this was already prepared on the weekend.
As for the formatting changes in the last request. You are right: those are simply the ruff formatter auto-changes. I'll try to split those into a separate commit next time.