chore: update deps

.github/workflows/pr_on_master.yml

@@ -1,27 +1,22 @@
-# File for Pull Request on master branch
 name: PR on master
 
-# When a PR is opened to master
 on:
   pull_request:
-    branches:
-      - master
+    branches: [master]
     types: [opened, reopened, synchronize]
 
 jobs:
   build:
-    # Setup OS and Node Version
     runs-on: ubuntu-latest
+
     strategy:
       matrix:
-        # Latest nodes only
         node-version: [18.x]
-        # Define Steps
+
     steps:
-      # Checkout code
-      - uses: actions/checkout@v4
+      - name: Checkout code
+        uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.pull_request.head.ref }}
           fetch-depth: 0
 
       - name: Use Node.js ${{ matrix.node-version }}
@@ -30,20 +25,22 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: 'npm'
 
-      # Make sure we have all branches
-      - name: Fetch other branches
-        run: git fetch --no-tags --prune --depth=5 origin master
-
-      - uses: nrwl/nx-set-shas@v4
+      - name: Set NX SHAs
+        uses: nrwl/nx-set-shas@v4
         with:
           main-branch-name: 'master'
 
-      - name: Install environment
-        run: npm ci --include=dev
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Lint affected projects
+        run: npx nx affected --target=lint --parallel=3
+
+      - name: Check formatting
+        run: npx nx format:check --base=origin/master --verbose
+
+      - name: Test affected projects
+        run: npx nx affected --target=test --parallel=3 --ci --code-coverage --verbose
 
-      - run: npx nx lint
-      - run: npx nx format:write --base="origin/master" --code-coverage --verbose
-      - run: npx nx format:check --base="origin/master" --code-coverage --verbose
-      - run: npx nx affected --target=lint --parallel=3
-      - run: npx nx affected --target=test --parallel=3 --ci --code-coverage --verbose
-      - run: npx nx affected --target=build --parallel=3
+      - name: Build affected projects
+        run: npx nx affected --target=build --parallel=3

.gitignore

@@ -44,3 +44,10 @@ Thumbs.db
 
 # Nx Cache
 .nx
+.cursor/rules/nx-rules.mdc
+.github/instructions/nx.instructions.md
+
+.cursor\rules\nx-rules.mdc
+.github\instructions\nx.instructions.md
+
+.github/instructions/

.husky/commit-msg

@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
 npx --no-install commitlint --edit $1

.husky/pre-commit

@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
 npx --no-install lint-staged

.prettierignore

@@ -13,4 +13,5 @@
 
 package-lock.json
 
-/.nx/workspace-data
+/.nx/workspace-data
+/.nx/cache

.vscode/settings.json

@@ -1,7 +1,9 @@
 {
     "cSpell.words": [
+        "fontawesome",
         "Pokedex",
         "rbtechdev",
         "Winboxes"
-    ]
+    ],
+    "nxConsole.generateAiAgentRules": true
 }

apps/winbox-example-app-e2e/cypress.config.ts

@@ -3,13 +3,15 @@ import { defineConfig } from 'cypress';
 
 export default defineConfig({
   e2e: {
-    ...nxE2EPreset(__dirname),
-    /**
-     * TODO(@nx/cypress): In Cypress v12,the testIsolation option is turned on by default.
-     * This can cause tests to start breaking where not indended.
-     * You should consider enabling this once you verify tests do not depend on each other
-     * More Info: https://docs.cypress.io/guides/references/migration-guide#Test-Isolation
-     **/
-    testIsolation: false,
+    ...nxE2EPreset(__filename, {
+      cypressDir: 'src',
+      webServerCommands: {
+        default: 'npx nx run test-angular:serve',
+        production: 'npx nx run test-angular:serve-static',
+      },
+      ciWebServerCommand: 'npx nx run test-angular:serve-static',
+      ciBaseUrl: 'http://localhost:4200',
+    }),
+    baseUrl: 'http://localhost:4200',
   },
 });

apps/winbox-example-app-e2e/eslint.config.mjs

@@ -0,0 +1,37 @@
+import path from 'path';
+import baseConfig from '../../eslint.config.mjs';
+import cypress from 'eslint-plugin-cypress/flat';
+import tsParser from '@typescript-eslint/parser';
+
+export default [
+  cypress.configs['recommended'],
+  ...baseConfig,
+
+  // Ignora niente (opzionale)
+  {
+    ignores: ['!**/*', '**/commands.ts'],
+  },
+
+  // Override per file Cypress (E2E)
+  {
+    files: [
+      '**/*.cy.ts',
+      '**/*.cy.js',
+      'cypress/**/*.ts',
+      'cypress/**/*.js',
+      'apps/**/*-e2e/**/*.ts'
+    ],
+    languageOptions: {
+      parser: tsParser,
+      parserOptions: {
+         project: [path.resolve(import.meta.dirname, './tsconfig.eslint.json')],
+        tsconfigRootDir: import.meta.dirname
+      },
+    },
+    rules: {
+      'cypress/no-assigning-return-values': 'error',
+      'cypress/no-unnecessary-waiting': 'warn',
+      'cypress/assertion-before-screenshot': 'warn',
+    },
+  }
+];

apps/winbox-example-app-e2e/project.json

@@ -20,7 +20,7 @@
       }
     },
     "lint": {
-      "executor": "@nx/linter:eslint",
+      "executor": "@nx/eslint:lint",
       "outputs": ["{options.outputFile}"],
       "options": {
         "lintFilePatterns": ["apps/winbox-example-app-e2e/**/*.{js,ts}"]

apps/winbox-example-app-e2e/src/e2e/app.cy.ts

@@ -1,5 +1,4 @@
 import { getGreeting } from '../support/app.po';
-
 describe('winbox-example-app', () => {
   beforeEach(() => cy.visit('/'));
 

apps/winbox-example-app-e2e/tsconfig.eslint.json

@@ -0,0 +1,12 @@
+{
+  "extends": "./tsconfig.json",
+  "include": [
+    "src/**/*.ts",
+    "src/**/*.tsx",
+    "src/**/*.js",
+    "src/**/*.jsx",
+    "cypress/**/*.ts",
+    "apps/**/*-e2e/**/*.ts",
+    "cypress.config.ts"
+  ]
+}