Skip to content

Conversation

@dewabisma
Copy link
Collaborator

Summary

Remove multiple quests, now only one quest, so we overwrite the previous quest.

Changes

  • remove unnecessary quests screens & widgets
  • simplify submission input

Screenshots

Simulator Screenshot - iPhone 8 - 2025-12-24 at 15 10 44

@dewabisma dewabisma requested a review from n13 December 24, 2025 07:42
@n13
Copy link
Collaborator

n13 commented Dec 31, 2025

PR 346 Review: Simplify Quest Screen

Branch: feat/simplify-quest-screen

Summary

The PR consolidates the "King of The Raider" functionality into the main QuestsScreen and simplifies the submission flow, while removing the "King of The Shill" screen entirely.

Key Changes

  1. Consolidation: KingOfTheRaiderScreen has been deleted, and its logic (fetching, adding, deleting raid submissions) is now directly inside QuestsScreen.
  2. Simplification: RaidSubmissionActionSheet now only asks for the "Reply Tweet Link". The "Target Tweet Link" input was removed.
  3. Removal: KingOfTheShillScreen was deleted.
  4. Service Update: TaskmasterService.addRaidSubmission was updated to send only tweet_reply_link.

Review Feedback

1. Missing Functionality (Referrals)

The KingOfTheShillScreen contained features that are not present in the new QuestsScreen:

  • Displaying and copying the user's Referral Code.
  • Sharing the Referral Link.
  • Viewing Account Stats (Referrals, Sends, Reversals, Mining).

❓ Question: Is it intentional to completely remove the ability for users to see/share their referral code and view these stats? If they are needed, they should be added to QuestsScreen or another location.

2. Unused Code

In QuestsScreen.dart:

  • The method refreshStatsData calls ref.invalidate(accountsStatsProvider).
  • However, accountsStatsProvider is never watched or used in the build method.

✅ Recommendation: If the stats UI is indeed being removed, please remove refreshStatsData, the accountsStatsProvider import, and its invocation in onRefresh to avoid fetching unused data.

3. Backend Compatibility

  • TaskmasterService.addRaidSubmission now sends a JSON body with only { 'tweet_reply_link': ... }.

⚠️ Verification: Please ensure the backend endpoint (/raid-quests/submissions) has been updated to no longer require target_tweet_link.

4. Code Quality

  • The logic ported from KingOfTheRaiderScreen to QuestsScreen appears correct.
  • The extractXStatusId helper and submission handling follow existing patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants