Skip to content

Conversation

@kshyatt
Copy link
Member

@kshyatt kshyatt commented Jan 20, 2026

Move this logic out of #243 so we can merge it without dealing with weird Enzyme segfaults.

@kshyatt kshyatt requested a review from lkdvos January 20, 2026 09:52
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 0% with 133 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pullbacks/contract.jl 0.00% 36 Missing ⚠️
src/pullbacks/trace.jl 0.00% 27 Missing ⚠️
src/pullbacks/add.jl 0.00% 20 Missing ⚠️
ext/TensorOperationsChainRulesCoreExt.jl 0.00% 19 Missing ⚠️
src/indices.jl 0.00% 13 Missing ⚠️
...erationsMooncakeExt/TensorOperationsMooncakeExt.jl 0.00% 9 Missing ⚠️
src/pullbacks/common.jl 0.00% 7 Missing ⚠️
src/utils.jl 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/TensorOperations.jl 100.00% <ø> (ø)
src/utils.jl 0.00% <0.00%> (ø)
src/pullbacks/common.jl 0.00% <0.00%> (ø)
...erationsMooncakeExt/TensorOperationsMooncakeExt.jl 0.00% <0.00%> (ø)
src/indices.jl 39.13% <0.00%> (-50.87%) ⬇️
ext/TensorOperationsChainRulesCoreExt.jl 0.00% <0.00%> (ø)
src/pullbacks/add.jl 0.00% <0.00%> (ø)
src/pullbacks/trace.jl 0.00% <0.00%> (ø)
src/pullbacks/contract.jl 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lkdvos
lkdvos previously approved these changes Jan 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

Your PR no longer requires formatting changes. Thank you for your contribution!

@kshyatt kshyatt requested a review from lkdvos January 20, 2026 14:16
@lkdvos
Copy link
Member

lkdvos commented Jan 20, 2026

I split up the functions a bit more so we can reuse some more functionality in the ChainRules extension as well.

Additionally, I cleaned up some of the index magic as preparatory work to more easily define these functions in TensorKit as well, hopefully removing a bit more of the boiler plate code that is required there as well.
Hopefully 🤞 everything passes now, let me know what you think since it is a bit of a substantial refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants