CHANGE logging from Napier to Kermit #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/template-199-kermit-logger
feature/template-199-kermit-logger
feature/template-199-kermit-logger
ninovanhooff
changed the title
kseniia-q42
reviewed
Jan 23, 2026
| dependencies { | ||
| implementation(libs.napier) | ||
| } | ||
| implementation(libs.napier) // todo remove |
| FirebaseCrashlytics.getInstance().isCrashlyticsCollectionEnabled = true | ||
| Napier.base(CrashlyticsLogger()) | ||
|
|
||
| Logger.setMinSeverity(Severity.Warn) |
Collaborator
There was a problem hiding this comment.
It seems to me that previously we determined which logs would be logged and which would not within CrashlyticsLogger, but now it will be a global filter for all events, correct? Perhaps it is worth retaining the definition of what to do with events within CrashlyticsLogger
It also seems to me that we logged debug and above in Crashlytics, not only warn and above
| dependencies { | ||
| implementation project(':core:utils') | ||
| implementation(libs.napier) | ||
| implementation(libs.napier) // todo remove |
| @@ -1,5 +1,6 @@ | |||
| [versions] | |||
Collaborator
There was a problem hiding this comment.
should we remove napier from here also?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this important?
Notes
implements #199