Add s5e device and product data examples#737
Merged
allenporter merged 1 commit intoPython-roborock:mainfrom Jan 8, 2026
Merged
Add s5e device and product data examples#737allenporter merged 1 commit intoPython-roborock:mainfrom
allenporter merged 1 commit intoPython-roborock:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test data files for the Roborock S5 Max (S5E model) device. The files contain product schema definitions and device state examples that will be parsed as part of the mock data loading module to verify correctness, though they are not currently used in active tests.
- Adds product schema definition with 17 device capabilities/properties
- Adds device state example with realistic status values
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/testdata/home_data_product_s5e.json | Product schema definition for roborock.vacuum.s5e model with standard vacuum capabilities including RPC, error codes, state, battery, fan power, water box mode, brush/filter life indicators, and various task/status events |
| tests/testdata/home_data_device_s5e.json | Device instance example for S5E with device metadata, Tuya integration details, and current device status values that reference the product schema IDs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not used in any tests, but saved for future use. They are parsed as part of the mock data loading module to verify they are correct, but then not used.