Update cli.py / device_manager.py to use get_home_data_v3 and discovered Roborock Q10 devices#418
Conversation
allenporter
left a comment
There was a problem hiding this comment.
Two problems:
(1) Commit style is not matching the expected commit style. Please amend the last commit with feat: XXX and force push
(2) The tests are not passing with this change
Thanks. I will check that.
Perhaps the version needs to be adapted to the device model. |
It's because the test mocks out the get home data call and the call changed to be a different call. The test just needs to be updated to match the other call. |
Use get_home_data_v3 to discovered Roborock Q10 devices Update device_manager.py to use get_home_data_v3
Fixed now
I updated the tests. |
Lash-L
left a comment
There was a problem hiding this comment.
Completely fine using v3 - but just to temper expectations, this makes t get discovered, but it can't actually fully integrate yet
|
Thanks |
Use get_home_data_v3 to discovered Roborock Q10 devices
I was able to discover my Q10 device after cloning this repo (36f5f2b) and changing to v3 :