Conversation
|
Thanks! I'll merge once tests pass (ignoring commitlint, i will fix that during merge) Is your Saros 10R still working? Are you fully up to date firmware wise? Most 10R's have been updating their protocol version from what i have seen. |
|
Can you fix the code lint @starkillerOG ? |
|
Yes I already performed a firmware update. I should be fully up to date. I did not specifically test this code with the Saros 10R, but can easily do that if required. I will fix the linting tomorrow, no problem. |
|
@Lash-L This should fix the linting error |
| high = 203 | ||
| custom = 204 | ||
| extreme = 250 | ||
| vac_followed_by_mop = 235 |
There was a problem hiding this comment.
Hi, I am getting similar codes on my Saros 10 (non R) but this one I don't get, are you sure it's also under the water_box_mode field?
There was a problem hiding this comment.
Yes, I checked quite throughly.
It happens when selecting the mode "vac followed by mop" instead of "vacuum & mop", then don't change any of the settings like water flow, otherwise it goes back to "vacuum & mop"
There was a problem hiding this comment.
if water_box_mode is set to 235 when in vac followed by mop, what does changing the mop intensity to "extreme" (for example) (while in followed by mop mode) change actually?
There was a problem hiding this comment.
It will go back to the "vacuum & mop" and apply the "extreme" setting for the water flow.
(I think roborock could have made this better or more clear in their UI of the app...)
There was a problem hiding this comment.
I don't know what it is for my Saros 10, but 235 doesn't work and throws an error.
| low = 201 | ||
| medium = 202 | ||
| high = 203 |
There was a problem hiding this comment.
Are these actually called "low" "medium" and "high" for you in the Roborock app? For me it's "mild" "standard" and "Intense".
|
@Lash-L the tests are now passing, could you merge? |
Sorry I've been out of town two weekends in a row. Will do now |
|
@allenporter what is your general level of confidence that a HA version bump would not break everything? Most changes have been isolated or moves |
|
I am not aware of anything risky and the intent has been to have no breaking changes. I only have one device to test with however. |
4 participants
No description provided.