fix: Prevent crashes from View.refresh

[NeloBlivion]

Summary

Pycord currently has an issue with race conditions in views - sometimes when editing a message or interaction response, the gateway will receive said message's MESSAGE_UPDATE from Discord and attempt to internally refresh the view before ViewStore has updated.

Traceback (most recent call last):
...
  File "/.../lib/python3.12/site-packages/discord/state.py", line 795, in parse_message_update
    self._view_store.update_from_message(raw.message_id, data["components"])
  File "/.../lib/python3.12/site-packages/discord/ui/view.py", line 807, in update_from_message
    view.refresh(components)
  File "/.../lib/python3.12/site-packages/discord/ui/view.py", line 610, in refresh
    item.refresh_component(c)
  File "/.../lib/python3.12/site-packages/discord/ui/container.py", line 371, in refresh_component
    x.refresh_component(y)
  File "/.../lib/python3.12/site-packages/discord/ui/section.py", line 268, in refresh_component
    for x, y in zip(self.items, component.components):
                                ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'TextDisplay' object has no attribute 'components'
# The client received a TextDisplay where it was expecting a Section, because that was the structure of the OLD view.

This is meant to be circumvented through remove_message_tracking, but this is not possible in response edit scenarios where the library may not have knowledge of the relevant message_id beforehand.

This PR:

• Attempts to refresh using the internal _original_response that's now returned from all interactions
• If the refresh fails, be less distruptive with logging.warning
• Renames refresh to reduce likelihood of being overridden by users

I'm not certain if the first change is entirely appropriate - if this happens to target the wrong message, I will instead revert that specfic change.

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.

[pycord-app]

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3059/head:pr-3059
git checkout pr-3059

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3059/head

[Paillat-dev]

(I am nitpicking, pr lgtm di per se)

[Paillat-dev]

Oh and changelog

[Paillat-dev]

I'd add an overrideable alias from refresh to _refresh with a deprecation warning, although it's not strictly necessary, I'm sure some people used this method for whatever reason, and while it wasn't documented, it was in fact private.

[Dorukyum]

Because it wasn't documented I don't think a deprecation warning is necessary.

[Paillat-dev]

@Lumabots Can you run your test bot on this pr for some time or something like that ?

[Lumabots]

@Lumabots Can you run your test bot on this pr for some time or something like that ?

yep
after 12h no crashs or nothing restart, disconnection reconnection etc and no error to report

[Paillat-dev]

@Lumabots You tested using views and stuff ?

[Lumabots]

@Lumabots You tested using views and stuff ?

Yep, using view, timeout, persistent view replace item add item remove item etc

[Paillat-dev]

In case you missed it @NeloBlivion I left a couple comments here

[Dorukyum]

Because it wasn't documented I don't think a deprecation warning is necessary.