refactor: upgrade Gemini SDK, improve logging, and update Tree-sitter bindings #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ctypes for compatibility with tree-sitter 0.21.x
- Implement Cpp_RACE_extractor for extracting sources and sinks related to race conditions. - Update dfbscan.py to include Cpp_RACE_extractor. - Modify path_validator.json to include RACE detection guidelines. - Update repoaudit.py to support RACE as a bug type. - Adjust run_repoaudit.sh to set default bug type to RACE. - Create race.c as a benchmark for testing race condition detection.
Contributor
chengpeng-wang
left a comment
chengpeng-wang
left a comment
There was a problem hiding this comment.
Thank you for your contribution! The patch looks good overall. However, race detection is essentially quite complex and the one you currently implemented only models a specific pattern. To fully support race detection, we need to implement additional symbolic components for the thread reasoning in the tsanalyzer. Therefore, we prefer not to integrate the race detector in this version.
To move forward with the patch merge, could you please remove the changes from commit 238719? This will allow us to merge the other changes first.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to the codebase, focusing on updating integrations with third-party LLM APIs (especially Google's Gemini), improving logging and error handling, and modernizing the way Tree-sitter language libraries are loaded. The changes enhance compatibility, robustness, and observability across key modules.
LLM Integration and Logging Improvements:
LLM_utils.pyto use the latestgoogle-genaiSDK, updated safety settings, improved model selection logic, and enhanced error/log reporting for better observability.Tree-sitter Language Loading Modernization:
TS_analyzer.pyto usectypesfor loading Tree-sitter language libraries, avoiding deprecation warnings and improving compatibility with Tree-sitter 0.21.x; includes a fallback to the deprecated method for stability.ctypesimport toTS_analyzer.pyto support the new loading mechanism.Minor Dependency and Import Cleanups:
build.pyand adjusted the import style fortree_sitter'sLanguage.These changes collectively improve maintainability, API compatibility, and developer experience.