Deduplicate TokenSpan interface definition #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Co-authored-by: Sander-Toonen <5106372+Sander-Toonen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update documentation based on feedback from PR #37
Deduplicate TokenSpan interface definition
Jan 23, 2026
Sander-Toonen
approved these changes
Jan 23, 2026
There was a problem hiding this comment.
Pull request overview
This PR removes a duplicated TokenSpan interface definition by consolidating it in ls-utils.ts and updating consumers to import it from there.
Changes:
- Removed the duplicate
TokenSpaninterface fromdiagnostics.ts. - Updated
diagnostics.tsto importTokenSpanfromls-utils.ts. - Updated
language-service.tsto importTokenSpanfromls-utils.tsinstead ofdiagnostics.ts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/language-service/language-service.ts | Switches TokenSpan import source to the single canonical definition in ls-utils.ts. |
| src/language-service/diagnostics.ts | Removes the local TokenSpan interface and imports the shared type from ls-utils.ts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TokenSpaninterface was defined identically in bothls-utils.tsanddiagnostics.ts, creating a maintenance liability.Changes
TokenSpaninterface fromdiagnostics.tsdiagnostics.tsto referencels-utils.tslanguage-service.tsto referencels-utils.tsThe interface is now defined once in
ls-utils.tsand imported where needed.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.