Add missing MEL log levels to the LogLevel validation (#2235)#2236
Merged
andyleejordan merged 2 commits intoPowerShell:mainfrom Sep 3, 2025
Merged
Add missing MEL log levels to the LogLevel validation (#2235)#2236andyleejordan merged 2 commits intoPowerShell:mainfrom
LogLevel validation (#2235)#2236andyleejordan merged 2 commits intoPowerShell:mainfrom
Conversation
Collaborator
|
Thanks! I added a change to translate the legacy levels to the MEL levels so that all options work as expected. @andyleejordan, can you remind me why this EDIT: Looking at this history it looks like it is |
JustinGrote
approved these changes
Jul 23, 2025
Collaborator
JustinGrote
left a comment
JustinGrote
left a comment
There was a problem hiding this comment.
Approved with MEL translation added
…ervices.ps1 (PowerShell#2235) This commit adds `Trace`, `Debug`, `Information`, `Critical`, and `None` to the validation set on the `LogLevel` parameter when starting PSES using `Start-EditorServices.ps1` to allow for the adoption of the newer MEL log levels.
andyleejordan
force-pushed
the
add-mel-loglevels
branch
from
508f6d5 to
78ac77d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
Trace,Debug,Information,Critical, andNoneto the validation set on theLogLevelparameter when starting PSES usingStart-EditorServices.ps1to allow for the adoption of the newer MEL log levels (#2200), closing #2235.Context
The
ValidationSetdefined forLogLevelhere: Start-EditorServices.ps1:49 was left out during the work done to enhance logging, meaning that the only MEL levels you can practically use are the ones that are the same as the legacy log levels. I chose to add the missing ones as opposed to replacing the old with the new for compatibility reasons which matched the sentiment conveyed in the code. I've included a bit more details in the issue I opened (#2235).