Skip to content

Fix download on photobooth images (we're saving Valentines Day)#15027

Closed
hannogrimm wants to merge 1 commit intoPostHog:masterfrom
hannogrimm:patch-5
Closed

Fix download on photobooth images (we're saving Valentines Day)#15027
hannogrimm wants to merge 1 commit intoPostHog:masterfrom
hannogrimm:patch-5

Conversation

@hannogrimm
Copy link
Contributor

Changes

The download process of photobooth images is broken on prod right now (buhu) because an error gets in the way before preparing the download.

I added a try-catch to ensure that the error does not block the (functional) html-to-image process.
Applied to Strip and Card, and refactored the process.

Error on production:
TypeError: can't access property "trim", e is undefined in embed-webfonts.js.

This likely happens because the cross-origin stylesheets of Google Fonts cannot be read, leading to undefined values.

SCR-20260213-pqax

Tested the fix on local on latest master version:
SCR-20260213-pvda

Download works again:
posthog_photobooth(1)

Checklist

  • I've read the docs and/or content style guides.
  • Words are spelled using American English
  • [] Use relative URLs for internal links
  • I've checked the pages added or changed in the Vercel preview build
  • If I moved a page, I added a redirect in vercel.json

@vercel
Copy link

vercel bot commented Feb 13, 2026

@hannogrimm is attempting to deploy a commit to the PostHog Team on Vercel.

A member of the Team first needs to authorize it.

@hannogrimm
Copy link
Contributor Author

@smallbrownbike will you be my valentine? 🙏 🫶 (tagging you since you made previous photobooth changes)

@smallbrownbike
Copy link
Collaborator

thank you for calling this out! seems like a firefox-specific issue. just merged a fix for this in another pr (needed to be fixed on a couple of other pages too).

shoot me an email (eli @ ____) so i can hook you up with some merch for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments