Fix download on photobooth images (we're saving Valentines Day)#15027
Closed
hannogrimm wants to merge 1 commit intoPostHog:masterfrom
Closed
Fix download on photobooth images (we're saving Valentines Day)#15027hannogrimm wants to merge 1 commit intoPostHog:masterfrom
hannogrimm wants to merge 1 commit intoPostHog:masterfrom
Conversation
|
@hannogrimm is attempting to deploy a commit to the PostHog Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@smallbrownbike will you be my valentine? 🙏 🫶 (tagging you since you made previous photobooth changes) |
Collaborator
|
thank you for calling this out! seems like a firefox-specific issue. just merged a fix for this in another pr (needed to be fixed on a couple of other pages too). shoot me an email (eli @ ____) so i can hook you up with some merch for the effort! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The download process of photobooth images is broken on prod right now (buhu) because an error gets in the way before preparing the download.
I added a try-catch to ensure that the error does not block the (functional) html-to-image process.
Applied to Strip and Card, and refactored the process.
Error on production:
TypeError: can't access property "trim", e is undefined in embed-webfonts.js.This likely happens because the cross-origin stylesheets of Google Fonts cannot be read, leading to undefined values.
Tested the fix on local on latest

masterversion:Download works again:

Checklist
vercel.json