fix(controlplane): eliminate systemd tracking warning and metrics port conflict#201
Merged
fuziontech merged 2 commits intomainfrom Feb 14, 2026
Merged
fix(controlplane): eliminate systemd tracking warning and metrics port conflict#201fuziontech merged 2 commits intomainfrom
fuziontech merged 2 commits intomainfrom
Conversation
… handover drain
When the PG listener is closed during handover, acceptLoop's `return` caused
RunControlPlane() → main() to exit, killing all in-flight connection goroutines
before the drain logic in handleHandoverRequest could complete. Replace `return`
with `select {}` so the main goroutine blocks until the handover handler (or
shutdown handler) calls os.Exit(0) after properly draining connections.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ics port conflict Two fixes for zero-downtime handover: 1. selfExec now double-forks via `setsid --fork` when running under systemd (NOTIFY_SOCKET set). The new CP is reparented to PID 1, allowing systemd to properly track it via waitpid() for Restart=always. Outside systemd (tests), the direct spawn path is preserved for fast crash recovery via cmd.Wait(). A 30s timeout provides crash recovery for the detached path. 2. initMetrics retries binding :9090 until available. During handover the old CP still holds the metrics port until it drains and exits; the new CP's metrics goroutine now retries instead of dying on first failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selfExecnow double-forks viasetsid --forkso the new CP is reparented to PID 1 — eliminates theSupervising process X which is not our childwarning and ensuresRestart=alwaysworks if the new CP crashesinitMetricsretries binding:9090until available instead of dying on first failure — during handover the old CP holds the port until drain completesreloadingflag after successful handover to prevent the 30s timeout recovery from interfering with long drainsTest plan
Supervising process X which is not our childwarning🤖 Generated with Claude Code