fix(controlplane): prevent connection drops during zero-downtime handover#200
Merged
fuziontech merged 1 commit intomainfrom Feb 14, 2026
Merged
fix(controlplane): prevent connection drops during zero-downtime handover#200fuziontech merged 1 commit intomainfrom
fuziontech merged 1 commit intomainfrom
Conversation
… handover drain
When the PG listener is closed during handover, acceptLoop's `return` caused
RunControlPlane() → main() to exit, killing all in-flight connection goroutines
before the drain logic in handleHandoverRequest could complete. Replace `return`
with `select {}` so the main goroutine blocks until the handover handler (or
shutdown handler) calls os.Exit(0) after properly draining connections.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acceptLoopreturned, causingRunControlPlane()→main()to exit and kill all in-flight connection goroutines before the drain logic inhandleHandoverRequestcould completereturnwithselect {}so the main goroutine blocks until the handover/shutdown handler callsos.Exit(0)after properly draining connectionsTestHandoverDrainsBeforeExitregression test that holds an idle connection open during handover and verifies the old CP stays alive to drain itTest plan
TestHandoverDrainsBeforeExitpasses with fix, fails without itsystemctl reload duckgrespreserves active psql sessions🤖 Generated with Claude Code