Fix additional transpiler issues found during audit#127
Open
Conversation
Comprehensive audit revealed additional issues similar to #126: 1. InformationSchemaTransform missing ColumnRef handling - Column refs like columns.column_name not rewritten when table renamed - Added Node_ColumnRef case to rewrite qualified column references 2. PgCatalogTransform missing ColumnRef handling (same as #126) - Included here for completeness as this branch is based on main 3. TypeCastTransform missing type mappings for common PostgreSQL types - decimal, boolean, date, uuid, bit -> keep same, strip pg_catalog prefix - xml, varbit, name -> convert to varchar - oid -> convert to integer Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive audit of the transpiler revealed additional issues similar to #126:
InformationSchemaTransformmissingColumnRefhandlingTypeCastTransformmissing type mappings for common PostgreSQL typesPgCatalogTransformColumnReffix (same as Fix pg_catalog column reference and json typecast transpilation #126, for completeness)Issues Found & Fixed
1. InformationSchemaTransform missing ColumnRef handling
Same bug pattern as #126. When
information_schema.columnsis rewritten toinformation_schema_columns_compat, column references likecolumns.column_namewere not being updated.2. TypeCastTransform missing type mappings
The following types with
pg_catalog.prefix were not handled:decimaldecimalbooleanbooleandatedateuuiduuidbitbitxmlvarcharvarbitvarcharnamevarcharoidinteger3. PgCatalogTransform ColumnRef handling
Same fix as #126, included here since this branch is based on main.
Test plan
🤖 Generated with Claude Code