Call disconnect callback after client removal#124
Open
MaelkMark wants to merge 1 commit intoPithikos:masterfrom
Open
Call disconnect callback after client removal#124MaelkMark wants to merge 1 commit intoPithikos:masterfrom
MaelkMark wants to merge 1 commit intoPithikos:masterfrom
Conversation
Call the self.client_left() disconnect callback after removing the client from the self.clients list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call the
self.client_left()disconnect callback after removing the client from theself.clientslist.When a client disconnects, it first removes the client from the
self.clientslist, and only then calls theself.client_left()callback to make sure the program doesn't get false data. Just like when a new client connects: first it adds the client to theself.clientslist and only then calls theself.new_clientcallback.This change makes the connection/disconnection callbacks more reliable and consistent.