Cleanup ompl servo #467
Cleanup ompl servo #467
Conversation
suchkristenwow
force-pushed
the
cleanup-ompl-servo
branch
from
0e2d825 to
fcdf4a6
Compare
src/factory_sim/config/config.yaml
Outdated
| ompl_planning: | ||
| package: "factory_sim" | ||
| path: "config/moveit/ompl_planning.yaml" | ||
| stomp_planning: |
There was a problem hiding this comment.
Let's remove the stomp_planning config entries and associated stomp_planning.yaml files as well. Those were part of the old MoveIt2 planning pipeline which doesn't exist anymore, so they can go away, as OMPL
Dockerfile
Outdated
|
|
||
| # Set up the user's .bashrc file and shell. | ||
| CMD ["/usr/bin/bash"] | ||
|
|
There was a problem hiding this comment.
Does this Dockerfile change belong to this PR?
There was a problem hiding this comment.
No I think this got pulled in via abuse of squash. Will be sure to remove anything unrelated.
src/hangar_sim/launch/fuse.launch.py
Outdated
| @@ -0,0 +1,101 @@ | |||
| #! /usr/bin/env python3 | |||
There was a problem hiding this comment.
Is this new fuse.launch.py related to this PR?
marioprats
left a comment
marioprats
left a comment
There was a problem hiding this comment.
Almost 3k lines of configs removed! Excited about this change
JWhitleyWork
force-pushed
the
cleanup-ompl-servo
branch
from
fcdf4a6 to
7e8a57f
Compare
suchkristenwow
force-pushed
the
cleanup-ompl-servo
branch
from
7e8a57f to
9d38d17
Compare
suchkristenwow
force-pushed
the
cleanup-ompl-servo
branch
from
a4d57fd to
0f1847c
Compare
marioprats
left a comment
marioprats
left a comment
There was a problem hiding this comment.
Looks good to me.
Tried three different configs (lab_sim, multi_arm_sim and hangar_sim), all with Pose Jog / Joint Jog working!
Removed references to /configs for ompl planner, servo planner and stomp planner (still in the external dependencies)