Added sources of gaining rage #1613
Conversation
MrHB212
commented
Dec 15, 2025
MrHB212
commented
MrHB212
changed the title
This reverts commit ced2e68.
MrHB212
changed the title
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
Just needs to change to be more generic so in the future we can support other mods like range on spell hit or range on arrow hit etcc
src/Modules/ModParser.lua
Outdated
| flag("Condition:CanGainRage"), | ||
| }, | ||
| ["gain (%d+) rage on melee hit"] = function(num) return { | ||
| mod("RageOnMeleeHit", "BASE", num), |
There was a problem hiding this comment.
Should use ModFlag.Melee as a way to only have it work on Melee skills
src/Modules/CalcSections.lua
Outdated
| { label = "Total", { format = "{0:output:Rage}", }, }, | ||
| { label = "Rage Effect", { format = "{1:output:RageEffect}", { modName = "RageEffect" }, }, }, | ||
| { label = "Maximum Rage", { format = "{0:output:MaximumRage}", { modName = "MaximumRage" }, }, }, | ||
| { label = "Gain on Melee hit", { format = "{0:output:RageOnMeleeHit}", { modName = "RageOnMeleeHit" }, }, }, |
There was a problem hiding this comment.
Should change to be Gain on Hit so it can work for other sources
src/Modules/ModParser.lua
Outdated
| }end, | ||
| ["gain %d+ rage on melee weapon hit"] = { | ||
| flag("Condition:CanGainRage"), | ||
| flag("Condition:CanGainRage") |
There was a problem hiding this comment.
Can use the weapon modflag for this similar to how we handle other weapon hit mods
There was a problem hiding this comment.
I actually deleted that parse since it seemed like a duplicate to me, the nodes still work fine without that.
Also deleted 2719-2721 since it is just a duplicate
Will also look into the Rage supports now since they dont actually do anything. Edit: One of the nodes show "Rage on Hit" instead of "Rage on Melee Hit", dont know why. |
|
2 participants
