-
Notifications
You must be signed in to change notification settings - Fork 26
Enable Integrated Mode #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enable Integrated Mode #2786
Conversation
c166214 to
980585c
Compare
Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>
d5b5208 to
0eac598
Compare
| const testingMonitoring = ref(false); | ||
| const monitoringValid = ref<boolean | null>(null); | ||
| const connectionSaved = ref<boolean | null>(null); | ||
| const isIntegrated = window.defaultConfig.isIntegrated; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a thought that all the app constants should be loaded in a dedicated module, so that the direct window reference is constrained to a single location and can be changed out more easily
| var majorMinorPatch = "0.0.0"; | ||
|
|
||
| var attributes = typeof(ConstantsFile).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>(); | ||
|
|
||
| foreach (var attribute in attributes) | ||
| { | ||
| if (attribute.Key == "MajorMinorPatch") | ||
| { | ||
| majorMinorPatch = attribute.Value ?? "0.0.0"; | ||
| } | ||
| } | ||
|
|
||
| return majorMinorPatch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| var majorMinorPatch = "0.0.0"; | |
| var attributes = typeof(ConstantsFile).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>(); | |
| foreach (var attribute in attributes) | |
| { | |
| if (attribute.Key == "MajorMinorPatch") | |
| { | |
| majorMinorPatch = attribute.Value ?? "0.0.0"; | |
| } | |
| } | |
| return majorMinorPatch; | |
| var attributes = typeof(ConstantsFile).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>(); | |
| return attributes.SingleOrDefault(attribute => attribute.Key == "MajorMinorPatch")?.Value ?? "0.0.0" |
Alternative to #2782
Reviewer Checklist