Skip to content

Conversation

@mikeminutillo
Copy link
Member

@mikeminutillo mikeminutillo commented Jan 15, 2026

Alternative to #2782

  • Separates the ServicePulse application from it's host to enable integrating the application with other hosts
  • Adds an application setting to show if it is running in an integrated mode
    • Do not allow changing the ServiceControl URL
    • Do not show the ServicePulse version

Reviewer Checklist

  • Components are broken down into sensible and maintainable sub-components.
  • Styles are scoped to the component using it. If multiple components need to share CSS, then a .css file is created containing the shared CSS and imported into component scoped style sections.
  • Naming is consistent with existing code, and adequately describes the component or function being introduced
  • Only functions utilizing Vue state or lifecycle hooks are named as composables (i.e. starting with 'use');
  • No module-level state is being introduced. If so, request the PR author to move the state to the corresponding Pinia store.

Base automatically changed from genxp-3600-add-authentication to master February 6, 2026 02:26
@mikeminutillo mikeminutillo changed the title Enable Embedded Mode (on top of auth) Enable Integrated Mode Feb 6, 2026
@mikeminutillo mikeminutillo marked this pull request as ready for review February 6, 2026 06:07
const testingMonitoring = ref(false);
const monitoringValid = ref<boolean | null>(null);
const connectionSaved = ref<boolean | null>(null);
const isIntegrated = window.defaultConfig.isIntegrated;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a thought that all the app constants should be loaded in a dedicated module, so that the direct window reference is constrained to a single location and can be changed out more easily

Comment on lines +27 to +39
var majorMinorPatch = "0.0.0";

var attributes = typeof(ConstantsFile).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>();

foreach (var attribute in attributes)
{
if (attribute.Key == "MajorMinorPatch")
{
majorMinorPatch = attribute.Value ?? "0.0.0";
}
}

return majorMinorPatch;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var majorMinorPatch = "0.0.0";
var attributes = typeof(ConstantsFile).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>();
foreach (var attribute in attributes)
{
if (attribute.Key == "MajorMinorPatch")
{
majorMinorPatch = attribute.Value ?? "0.0.0";
}
}
return majorMinorPatch;
var attributes = typeof(ConstantsFile).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>();
return attributes.SingleOrDefault(attribute => attribute.Key == "MajorMinorPatch")?.Value ?? "0.0.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants