Skip to content

Update plugin load context #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bording wants to merge 3 commits into from
+12 −4
Closed

Update plugin load context #5324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cc8316
Update NServiceBus
bording Feb 13, 2026
e41f38c
Don't load assembly when higher version is already loaded
bording Feb 13, 2026
c689da7
Add debug logging to failing workflow
bording Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/build-db-container.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,16 @@ jobs:
shell: pwsh
run: |
$manifestCreate = "docker manifest create ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}"
echo "first"
$containers = cat src/ServiceControl.RavenDB/containers.json | ConvertFrom-Json
echo "second"
$containers | ForEach-Object -Process {
$manifestCreate += " --amend ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}-$($_.tag)"
}
echo $manifestCreate
Invoke-Expression $manifestCreate
echo "third"
docker buildx imagetools inspect ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}
docker manifest push ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}
echo "fourth"
docker manifest push ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}
echo "fifth"
4 changes: 2 additions & 2 deletions src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
<PackageVersion Include="Microsoft-WindowsAPICodePack-Shell" Version="1.1.5" />
<PackageVersion Include="Mindscape.Raygun4Net.NetCore" Version="11.2.5" />
<PackageVersion Include="NLog.Extensions.Logging" Version="5.5.0" />
<PackageVersion Include="NServiceBus" Version="10.0.0" />
<PackageVersion Include="NServiceBus.AcceptanceTesting" Version="10.0.0" />
<PackageVersion Include="NServiceBus" Version="10.1.0" />
<PackageVersion Include="NServiceBus.AcceptanceTesting" Version="10.1.0" />
<PackageVersion Include="NServiceBus.AmazonSQS" Version="9.0.0" />
<PackageVersion Include="NServiceBus.CustomChecks" Version="6.0.0" />
<PackageVersion Include="NServiceBus.Extensions.Hosting" Version="4.0.0" />
Expand Down
4 changes: 3 additions & 1 deletion src/ServiceControl.Infrastructure/PluginAssemblyLoadContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ protected override Assembly Load(AssemblyName assemblyName)
// Since we ensure we are using the same version of dependencies in every project, it should be okay to use the already loaded copy.
foreach (var assembly in Default.Assemblies)
{
if (assembly.FullName == assemblyName.FullName)
var loadedAssembly = assembly.GetName();

if (loadedAssembly.Name == assemblyName.Name && loadedAssembly.Version >= assemblyName.Version)
{
return null;
}
Expand Down
Loading