Feature/discover data #31
Open
+203
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to start addressing #26
erikvansebille
approved these changes
Jan 21, 2026
| V.units = Geographic() | ||
| UV = VectorField(name="UV", U=U, V=V) | ||
| fieldset = FieldSet([UV, UV.U, UV.V]) | ||
| fieldset = FieldSet.from_fesom2(ds) |
Member
There was a problem hiding this comment.
Fine for now, but we should probably (soon) change this to a workflow
ds = convert.fesom2_to_ugrid(ds)
fieldset = FieldSet.from_ugrid_conventions(ds)which aligns better with the other model ingestion codes?
Contributor
Author
There was a problem hiding this comment.
agreed.. when that exists upstream in parcels, we'll switch to that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to discover new data and add it to a version controller registry/manifest in this repository. After experimenting with a few CLI tools, I landed on
typer; it's quite easy to use and creates useful help menus with properly documented functions. README has been updated to demonstrate the new option to discover a new dataset hosted in the SurfDrive.At the moment, benchmarks break due to changes in Parcels, but issues will be open for those.
Resolves #26