Implement the remaining attribute parsing #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… need a custom struct for parsing
…t when use cases are determined
prockallsyms
changed the title
Owner
|
This is all looking great, will merge when CI is happy 👍 |
added 2 commits
December 8, 2025 09:53
Owner
|
❤️ |
Author
|
Thanks for merging this PR! If you're interested, I was thinking about switching up the way the parsing is done. We could attempt to pivot from using nom to binrw so that we can modify & write class files. This sets up use for tooling other than a Rusty JVM, such as decompilers and patchers (testing tooling mostly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of the JVM spec parsing is hopefully complete!
Unsure if the tests are in the right spot. Additionally added a dependency on binrw for future work towards the ability to load, modify, and re-write class files.