【Hackathon 10th Spring No.1】add param for MaxPool*D/max_pool*d #7724
+117
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinyouzhi
requested review from
Echo-Nie,
mattheliu,
ooooo-create and
sunzhongkai588
as code owners
|
感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-7724.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
📚 本次 PR 文档预览链接（点击展开）
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for the dilation parameter to MaxPool operations in PaddlePaddle, synchronizing with changes introduced in PaddlePaddle/Paddle#77495.
Changes:
- Added
dilationparameter documentation to all MaxPool API variants (1D, 2D, 3D) - Minor punctuation fix in MaxPool3D padding parameter description
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/api/paddle/nn/functional/max_pool3d_cn.rst | Added dilation parameter documentation for max_pool3d function |
| docs/api/paddle/nn/functional/max_pool2d_cn.rst | Added dilation parameter documentation for max_pool2d function |
| docs/api/paddle/nn/functional/max_pool1d_cn.rst | Added dilation parameter documentation for max_pool1d function |
| docs/api/paddle/nn/MaxPool3D_cn.rst | Added dilation parameter documentation and fixed missing period in padding description |
| docs/api/paddle/nn/MaxPool2D_cn.rst | Added dilation parameter documentation for MaxPool2D class |
| docs/api/paddle/nn/MaxPool1D_cn.rst | Added dilation parameter documentation for MaxPool1D class |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
ready for review @zhwesky2010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dilationoption for MaxPool1D/2D/3D -part Paddle#77495MaxPool*D/FractionalMaxPool*Dparam alias -part Paddle#77681