-
Notifications
You must be signed in to change notification settings - Fork 13
Update PEtab extensions #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Rephrase and rearrange some extension-related parts: * Trying to make the PEtab 2.0 specs more self-contained * Separate process and specs for PEtab extensions * Avoid using "extension" to refer to different things
matthiaskoenig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Do we have any extensions which are currently used? If yes it makes sense to list them on the webpage.
There's this: Lines 112 to 128 in 26c4fb2
|
| Extensions of this format (e.g., additional columns in the measurement table) | ||
| are allowed and encouraged. While such extensions can enhance plotting, | ||
| Additional non-standard columns are allowed in all PEtab tables. | ||
| While such extra column may, for example, contain metadata to enhance plotting, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| While such extra column may, for example, contain metadata to enhance plotting, | |
| While such extra columns may, for example, contain metadata to enhance plotting, |
| Additional non-standard columns are allowed in all PEtab tables. | ||
| While such extra column may, for example, contain metadata to enhance plotting, | ||
| downstream analysis, or improve efficiency in parameter estimation, they | ||
| should not alter the definition of the estimation problem itself. | ||
| must not alter the definition of the estimation problem itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this contradict the ability of extensions to alter the definition through new columns?
Or does "non-standard" include both "core" and "extension" columns?
Rephrase and rearrange some extension-related parts: