Skip to content

Conversation

@clement-ux
Copy link
Collaborator

@clement-ux clement-ux commented Jan 23, 2026

Contract

Name Address
CurvePoolBoosterFactory Mainnet 0xB6073788e5302122F4DfB6C5aD53a1EAC9cb0289
CurvePoolBoosterFactory Arbitrum 0xB6073788e5302122F4DfB6C5aD53a1EAC9cb0289
PoolBooster CentralRegistry Implem 0xb929fD0C424B0c5e19DCF2E32abd18E65A50D0F1

Governance

  • PoolBoostCentralRegistryProxy: upgradeTo 0xb929fD0C424B0c5e19DCF2E32abd18E65A50D0F1
  • PoolBoostCentralRegistry: approveFactory 0xB6073788e5302122F4DfB6C5aD53a1EAC9cb0289
  • Governance proposal link

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@clement-ux clement-ux marked this pull request as ready for review January 23, 2026 13:24
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.33%. Comparing base (7fbff1d) to head (1c5a1b3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   39.62%   39.33%   -0.30%     
==========================================
  Files         126      126              
  Lines        5825     5825              
  Branches     1546     1546              
==========================================
- Hits         2308     2291      -17     
- Misses       3515     3532      +17     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clement-ux clement-ux force-pushed the clement/deploy-166 branch 2 times, most recently from 1c5a1b3 to a2f494a Compare January 23, 2026 15:35
@sparrowDom
Copy link
Member

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
    • 🟡 PoolBoosterCentralRegistry shows governor slot position as a constructor argument even though the constructor takes no arguments: 7bea13895fa79d2831e0a9e28edede30099005a50d652d8957cf8a607ee6ca4a Which I think is a bit weird
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal
sol2uml diff 0xB6073788e5302122F4DfB6C5aD53a1EAC9cb0289 .,node_modules 
sol2uml diff 0xb929fD0C424B0c5e19DCF2E32abd18E65A50D0F1 .,node_modules 
sol2uml diff 0xB6073788e5302122F4DfB6C5aD53a1EAC9cb0289 .,node_modules  --network arbitrumOne

@clement-ux clement-ux merged commit ccb5abc into master Jan 24, 2026
28 of 47 checks passed
@clement-ux clement-ux deleted the clement/deploy-166 branch January 24, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants