Open
Conversation
…SecuritySystemCamera::FrameUpdate
…d GetAmmoInPocketFor virtual function to ICharacterCoreInventoryState
…et comment for m_pGeomEntity
OrfeasZ
requested changes
Feb 7, 2026
Mods/Player/Src/Player.cpp
Outdated
| s_Actor->m_fCurrentHitPoints = 0.f; | ||
| } | ||
|
|
||
| return HookResult<bool>(HookAction::Continue()); |
Owner
There was a problem hiding this comment.
Instead of having HookResult<bool>(HookAction::Continue()); (or similar) in all these, you could write `{ HookAction::Continue() }; to keep it a bit more concise.
Mods/Player/Src/Player.cpp
Outdated
Comment on lines
685
to
687
| const bool s_IsInfiniteAmmoEnabled = !s_LocalHitman.m_pInterfaceRef->IsCustomFlagEnabled( | ||
| static_cast<ECustomFlags>(0x2000000) | ||
| ); |
Owner
There was a problem hiding this comment.
Should this be a constant / enum value and this checked be moved to a function in ZHitman5, so it can be re-used?
| if (s_AmmoInPocket > 0) { | ||
| s_AmmoInPocket -= s_HM5ItemWeapon->GetMagazineCapacity(); | ||
|
|
||
| s_Inventory->m_nAmmoInPocket[static_cast<size_t>(s_AmmoType)] = s_AmmoInPocket; |
Owner
There was a problem hiding this comment.
Are we guaranteed to have an element in at this index?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.