Skip to content

Conversation

@Bashmunta
Copy link
Contributor

Add the Errors library to the utils README so that common custom error utilities are visible in the public API docs. This keeps the documentation in sync with the existing Errors.sol module and makes it easier for users to discover and reuse shared error types.

@Bashmunta Bashmunta requested a review from a team as a code owner December 9, 2025 10:09
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

⚠️ No Changeset found

Latest commit: c67eaac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Walkthrough

The change updates documentation in the utilities README file to include a new library reference. Specifically, it adds an entry for the Errors utility library to both the utilities list and the generated index of libraries. The modifications consist of documentation-only updates with no changes to functional code or exported entity declarations. The alterations involve adding the library reference and adjusting surrounding formatting for consistency with existing documentation structure.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: documenting the Errors utility library in the utils README. It is concise, specific, and clearly conveys the primary purpose of the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding the Errors library to the utils README and the benefits of keeping documentation in sync with the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce5e6ed and c67eaac.

📒 Files selected for processing (1)
  • contracts/utils/README.adoc (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: tests
  • GitHub Check: slither
  • GitHub Check: tests-upgradeable
  • GitHub Check: tests-foundry
  • GitHub Check: coverage
  • GitHub Check: Redirect rules - solidity-contracts
  • GitHub Check: halmos
  • GitHub Check: Header rules - solidity-contracts
  • GitHub Check: Pages changed - solidity-contracts

* {Multicall}: Abstract contract with a utility to allow batching together multiple calls in a single transaction. Useful for allowing EOAs to perform multiple operations at once.
* {Packing}: A library for packing and unpacking multiple values into bytes32.
* {Panic}: A library to revert with https://docs.soliditylang.org/en/v0.8.20/control-structures.html#panic-via-assert-and-error-via-require[Solidity panic codes].
* {Errors}: Collection of common custom errors used in multiple contracts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Alphabetical ordering issue in utilities list.

The Errors library is inserted between Panic and RelayedCall, but alphabetically it should be positioned between Create2 and InteroperableAddress (letter 'E' comes before 'I' and 'P'). Move the entry to maintain alphabetical consistency with the rest of the utilities list.

- * {Panic}: A library to revert with https://docs.soliditylang.org/en/v0.8.20/control-structures.html#panic-via-assert-and-error-via-require[Solidity panic codes].
+ * {Panic}: A library to revert with https://docs.soliditylang.org/en/v0.8.20/control-structures.html#panic-via-assert-and-error-via-require[Solidity panic codes].
+ * {Errors}: Collection of common custom errors used in multiple contracts.
- * {Errors}: Collection of common custom errors used in multiple contracts.
  * {RelayedCall}: A library for performing calls that use minimal and predictable relayers to hide the sender.

Actually, this needs to be placed earlier in the list. Apply this diff instead:

  * {Create2}: Wrapper around the https://blog.openzeppelin.com/getting-the-most-out-of-create2/[`CREATE2` EVM opcode] for safe use without having to deal with low-level assembly.
+ * {Errors}: Collection of common custom errors used in multiple contracts.
  * {InteroperableAddress}: Library for formatting and parsing ERC-7930 interoperable addresses.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In contracts/utils/README.adoc around line 42, the "Errors" entry is out of
alphabetical order (currently placed between Panic and RelayedCall); remove that
entry from its current spot and reinsert it earlier in the utilities list so it
appears between "Create2" and "InteroperableAddress" to maintain alphabetical
ordering.

Comment on lines +147 to +148
{{Errors}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Alphabetical ordering issue in Libraries section index.

The {{Errors}} entry is positioned between {{Panic}} and {{RelayedCall}}, which breaks alphabetical ordering. Move it to maintain consistency with the structured list above and alphabetical ordering within the Libraries section (between {{Create2}} and {{InteroperableAddress}}).

 {{Create2}}
 
+ {{Errors}}
+
  {{InteroperableAddress}}

And remove it from its current location:

 {{Panic}}
 
- {{Errors}}
-
  {{RelayedCall}}

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In contracts/utils/README.adoc around lines 147-148, the {{Errors}} index entry
is misplaced between {{Panic}} and {{RelayedCall}}, breaking the Libraries
section alphabetical order; remove the {{Errors}} occurrence at its current
location and reinsert a single {{Errors}} entry in the Libraries index between
{{Create2}} and {{InteroperableAddress}} so the list remains alphabetically
ordered and consistent with the structured list above.

@Amxx Amxx changed the base branch from master to typo-fixes December 15, 2025 14:17
@Amxx Amxx added this to the typo-fixes milestone Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants