Skip to content

Conversation

@MozirDmitriy
Copy link
Contributor

The governance guide was still suggesting that ERC20VotesComp is part of the current module set, even though it was removed in v5.0. This commit updates the compatibility section to describe only ERC20Votes as the voting extension used with Governor.

Amxx and others added 5 commits December 5, 2025 00:14
…elin#6167)

Co-authored-by: Luiz Vasconcelos Júnior <64055364+luiz-lvj@users.noreply.github.com>
Co-authored-by: ernestognw <ernestognw@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…age (OpenZeppelin#6160)

Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@MozirDmitriy MozirDmitriy requested a review from a team as a code owner December 6, 2025 20:22
@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2025

⚠️ No Changeset found

Latest commit: 8ca87e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 6, 2025

Walkthrough

The governance documentation has been updated to consolidate the ERC20Votes extension description. The entry previously describing two variants—ERC20Votes and ERC20VotesComp—has been renamed and reorganized to present a single unified ERC20Votes extension. The updated documentation now describes core features including support for token supplies exceeding 2^96 and voting power history that can be delegated and queried at past timepoints. References to the Comp variant and its compatibility considerations have been removed. No method signatures or interface changes were introduced.

Suggested labels

ignore-changeset

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: removing the stale ERC20VotesComp reference from the documentation, which is the primary objective of this PR.
Description check ✅ Passed The description is directly related to the changeset, explaining the context (ERC20VotesComp removal in v5.0) and the specific change made (updating compatibility section to reference only ERC20Votes).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce5e6ed and 8ca87e4.

📒 Files selected for processing (1)
  • docs/modules/ROOT/pages/governance.adoc (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - solidity-contracts
  • GitHub Check: Header rules - solidity-contracts
  • GitHub Check: Pages changed - solidity-contracts
🔇 Additional comments (1)
docs/modules/ROOT/pages/governance.adoc (1)

17-19: Documentation update correctly removes deprecated ERC20VotesComp reference.

The section consolidation cleanly removes the ERC20VotesComp variant, which was removed in OpenZeppelin Contracts v5.0.0. The updated ERC20Votes description accurately reflects current behavior—the extension now supports token supplies greater than 2^96 (previously limited to 96 bits in the Comp variant) and maintains voting power history. The remaining GovernorTimelockCompound reference at line 29 remains appropriate as that module still has a Control variant.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Amxx Amxx changed the base branch from master to typo-fixes December 8, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants