-
Notifications
You must be signed in to change notification settings - Fork 46
docs: update argument #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update argument #73
Conversation
Summary of ChangesHello @HardyNLee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求主要集中于更新和扩展命令参数的文档。它修正了现有参数的描述错误,澄清了坐标系定义,并为 Live2D 立绘新增了眨眼和注视控制参数的详细说明。此外,还改进了 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 主要更新了 changeFigure 和 setTransform 命令的文档,修正了部分描述错误并补充了 blink 和 focus 参数的说明。整体上提升了文档的准确性和完整性。我在代码中发现了一些可以改进的地方,主要涉及文档中的拼写错误、单位不一致、定义矛盾以及示例代码可以更清晰等方面。请查看具体的审查意见。
|
|
||
| 对于 Live2D 立绘,填写 json 字符串,控制立绘的注视参数。 | ||
| 通常不需要书写所有的属性, 没填写的属性会继承上一次设置的值, 立绘出场时会继承默认值。 | ||
| x 轴以向右为正方形向,y 轴以向上为正方向。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| 对于 Live2D 立绘,填写 number[4] 数组,拓展或收缩立绘的显示区域。 | ||
| 以向右和向下为正方向,顺序为 `左,上,右,下`。 | ||
| x 轴以向右为正方形向,y 轴以向下为正方向。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 通常不需要书写所有的属性, 没填写的属性会继承上一次设置的值, 立绘出场时会继承默认值。 | ||
|
|
||
| 参数有 | ||
| - `"blinkInterval"`: 数字,眨眼间隔,单位毫秒,默认值 24 小时 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| setTransform:{"scale":{"x":2,"y":2}} -target=aaa -duration=10000 -keep; | ||
| 角色A: 第一句话; | ||
| 角色A: 第二句话; | ||
| 角色A: 第三句话; | ||
| ; 这会打断 aaa 的跨语句动画,并播放新动画 | ||
| setTransform:{"scale":{"x":1,"y":1}} -target=aaa -duration=10000; | ||
| setTransform:{"scale":{"x":1,"y":1}} -target=aaa -duration=10000 -keep; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
根据 keep 参数的文档(keep.md),它 通常需要配合 next 参数一起使用。为了让示例更清晰地展示其非阻塞特性,并与 setTempAnimation 的示例保持一致,建议在示例中也加入 -next 参数。
| setTransform:{"scale":{"x":2,"y":2}} -target=aaa -duration=10000 -keep; | |
| 角色A: 第一句话; | |
| 角色A: 第二句话; | |
| 角色A: 第三句话; | |
| ; 这会打断 aaa 的跨语句动画,并播放新动画 | |
| setTransform:{"scale":{"x":1,"y":1}} -target=aaa -duration=10000; | |
| setTransform:{"scale":{"x":1,"y":1}} -target=aaa -duration=10000 -keep; | |
| setTransform:{"scale":{"x":2,"y":2}} -target=aaa -duration=10000 -keep -next; | |
| 角色A: 第一句话; | |
| 角色A: 第二句话; | |
| 角色A: 第三句话; | |
| ; 这会打断 aaa 的跨语句动画,并播放新动画 | |
| setTransform:{"scale":{"x":1,"y":1}} -target=aaa -duration=10000 -keep -next; |
介绍
eyesCloseboundssetTransform的文档blinkfocus的文档closes #72