Skip to content

Conversation

@HardyNLee
Copy link

介绍

  • 修正 eyesClose bounds setTransform 的文档
  • 补充 blink focus 的文档

closes #72

@gemini-code-assist
Copy link

Summary of Changes

Hello @HardyNLee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求主要集中于更新和扩展命令参数的文档。它修正了现有参数的描述错误,澄清了坐标系定义,并为 Live2D 立绘新增了眨眼和注视控制参数的详细说明。此外,还改进了 setTransform 命令的示例代码,以提高文档的准确性和完整性。

Highlights

  • 文档修正: 修正了 eyesClose 参数的文档描述,明确其用于闭眼时的立绘差分。
  • 坐标系说明: 补充了 bounds 参数的坐标系说明,明确了 x 轴和 y 轴的正方向。
  • 新增 blink 参数文档: 为 Live2D 立绘新增了 blink 参数的详细文档,包括其 JSON 格式的眨眼控制参数。
  • 新增 focus 参数文档: 为 Live2D 立绘新增了 focus 参数的详细文档,包括其 JSON 格式的注视点控制参数。
  • 示例代码更新: 更新了 setTransform 命令的示例,增加了 -keep 参数以更好地演示跨语句动画。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 主要更新了 changeFiguresetTransform 命令的文档,修正了部分描述错误并补充了 blinkfocus 参数的说明。整体上提升了文档的准确性和完整性。我在代码中发现了一些可以改进的地方,主要涉及文档中的拼写错误、单位不一致、定义矛盾以及示例代码可以更清晰等方面。请查看具体的审查意见。


对于 Live2D 立绘,填写 json 字符串,控制立绘的注视参数。
通常不需要书写所有的属性, 没填写的属性会继承上一次设置的值, 立绘出场时会继承默认值。
x 轴以向右为正方形向,y 轴以向上为正方向。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

这行文档存在两个潜在问题:

  1. 正方形向 疑似拼写错误,应为 正方向
  2. y 轴的正方向定义为向上,与 bounds 参数中 y 轴向下为正方向的定义(第 247-248 行)相矛盾。这种不一致性可能会导致用户混淆。请确认 focus 参数的坐标系定义是否正确。如果定义无误,建议在文档中特别强调与 bounds 的区别,并修正拼写错误。
Suggested change
x 轴以向右为正方形向,y 轴以向上为正方向。
x 轴以向右为正方向,y 轴以向上为正方向。


对于 Live2D 立绘,填写 number[4] 数组,拓展或收缩立绘的显示区域。
以向右和向下为正方向,顺序为 `左,上,右,下`
x 轴以向右为正方形向,y 轴以向下为正方向。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

这里似乎有一个拼写错误,正方形向 应该为 正方向

Suggested change
x 轴以向右为正方形向,y 轴以向下为正方向。
x 轴以向右为正方向,y 轴以向下为正方向。

通常不需要书写所有的属性, 没填写的属性会继承上一次设置的值, 立绘出场时会继承默认值。

参数有
- `"blinkInterval"`: 数字,眨眼间隔,单位毫秒,默认值 24 小时

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

blinkInterval 的单位是毫秒,但默认值写的是 “24 小时”,这可能会让使用者困惑。建议将默认值也用毫秒单位表示,即 86400000,以保持单位一致性。

Suggested change
- `"blinkInterval"`: 数字,眨眼间隔,单位毫秒,默认值 24 小时
- `"blinkInterval"`: 数字,眨眼间隔,单位毫秒,默认值 86400000

Comment on lines +44 to +49
setTransform:{"scale":{"x":2,"y":2}} -target=aaa -duration=10000 -keep;
角色A: 第一句话;
角色A: 第二句话;
角色A: 第三句话;
; 这会打断 aaa 的跨语句动画,并播放新动画
setTransform:{"scale":{"x":1,"y":1}} -target=aaa -duration=10000;
setTransform:{"scale":{"x":1,"y":1}} -target=aaa -duration=10000 -keep;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

根据 keep 参数的文档(keep.md),它 通常需要配合 next 参数一起使用。为了让示例更清晰地展示其非阻塞特性,并与 setTempAnimation 的示例保持一致,建议在示例中也加入 -next 参数。

Suggested change
setTransform:{"scale":{"x":2,"y":2}} -target=aaa -duration=10000 -keep;
角色A: 第一句话;
角色A: 第二句话;
角色A: 第三句话;
; 这会打断 aaa 的跨语句动画,并播放新动画
setTransform:{"scale":{"x":1,"y":1}} -target=aaa -duration=10000;
setTransform:{"scale":{"x":1,"y":1}} -target=aaa -duration=10000 -keep;
setTransform:{"scale":{"x":2,"y":2}} -target=aaa -duration=10000 -keep -next;
角色A: 第一句话;
角色A: 第二句话;
角色A: 第三句话;
; 这会打断 aaa 的跨语句动画,并播放新动画
setTransform:{"scale":{"x":1,"y":1}} -target=aaa -duration=10000 -keep -next;

@HardyNLee HardyNLee changed the title Feat command argument docs: update argument Nov 2, 2025
@MakinoharaShoko MakinoharaShoko merged commit da11820 into OpenWebGAL:main Nov 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

changeFigure 参数描述错误

2 participants