fix: override numpy<2 for megatron-core compatibility#565
Closed
vivekkalyan wants to merge 1 commit intomainfrom
Closed
fix: override numpy<2 for megatron-core compatibility#565vivekkalyan wants to merge 1 commit intomainfrom
vivekkalyan wants to merge 1 commit intomainfrom
Conversation
vLLM 0.15.1 pulls opencv-python-headless>=4.13 which requires numpy>=2 on Python 3.9+, but megatron-core requires numpy<2. Add a uv override-dependencies to cap numpy<2, resolving to 1.26.4. Verified on GPU VM that LocalBackend and Megatron both install and import correctly.
Collaborator
|
Seems this has been handled by #530 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencv-python-headless>=4.13viamistral-common[image], which requiresnumpy>=2on Python 3.9+megatron-core(installed separately in the training environment) requiresnumpy<2.0.0override-dependencies = ["numpy<2"]in[tool.uv]to force numpy 1.26.4, resolving the conflictTest plan
uv lockresolves cleanly (numpy 2.2.6 → 1.26.4)uv run prek run --all-filespasses locallyuv sync --extra backendinstalls numpy 1.26.4, vllm 0.15.1, opencv 4.13.0bash src/art/megatron/setup.shinstalls megatron-core 0.15.2 without conflicts