fix: move _internal_config assignment back into TrainableModel.__init__#559
Open
saurabhbikram wants to merge 1 commit intoOpenPipe:mainfrom
Open
fix: move _internal_config assignment back into TrainableModel.__init__#559saurabhbikram wants to merge 1 commit intoOpenPipe:mainfrom
saurabhbikram wants to merge 1 commit intoOpenPipe:mainfrom
Conversation
The _internal_config assignment was accidentally placed after a return statement inside _noop_cost_calculator, making it dead code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
_internal_configassignment inTrainableModelwas accidentally placed after areturn {}statement inside_noop_cost_calculator, making it dead code. This means_internal_configwas never actually set onTrainableModelinstances.This PR moves the 3 lines back into
__init__where they belong.Files changed
src/art/model.py— move_internal_configassignment from dead code in_noop_cost_calculatorback into__init__