fix: truncate excess scenarios instead of raising error in MCP generation#556
Open
saurabhbikram wants to merge 1 commit intoOpenPipe:mainfrom
Open
fix: truncate excess scenarios instead of raising error in MCP generation#556saurabhbikram wants to merge 1 commit intoOpenPipe:mainfrom
saurabhbikram wants to merge 1 commit intoOpenPipe:mainfrom
Conversation
When the LLM generates more scenarios than requested, truncate to the requested count instead of raising a ValueError. This makes scenario generation more robust since LLMs occasionally overshoot the count. Still raises an error when too few scenarios are generated. https://claude.ai/code/session_017Y9KNNQX2RyVWnqpj3A4hh
saurabhbikram
force-pushed
the
truncate-excess-scenarios
branch
from
a4907ed to
ef2b0fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
generate_scenarios(), the LLM occasionally generates more scenarios than the requestednum_scenarioscount. Previously this raised aValueError, forcing a retry. This PR changes the behavior to:ValueError(generation failed)This makes scenario generation more robust, especially with models that don't strictly respect JSON schema
maxItemsconstraints.Files changed
src/art/mcp/generate_scenarios.py— split the!=check into<(error) and>(truncate with log)