Skip to content

OmcSession logging #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syntron wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OmcSession logging #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions OMPython/OMCSession.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,8 +702,8 @@ def __del__(self):
if isinstance(self._omc_zmq, zmq.Socket):
try:
self.sendExpression("quit()")
except OMCSessionException:
pass
except OMCSessionException as exc:
logger.warning(f"Exception on sending 'quit()' to OMC: {exc}! Continue nevertheless ...")
finally:
self._omc_zmq = None

Expand All @@ -720,7 +720,7 @@ def __del__(self):
self._omc_process.wait(timeout=2.0)
except subprocess.TimeoutExpired:
if self._omc_process:
logger.warning("OMC did not exit after being sent the quit() command; "
logger.warning("OMC did not exit after being sent the 'quit()' command; "
"killing the process with pid=%s", self._omc_process.pid)
self._omc_process.kill()
self._omc_process.wait()
Expand Down
Loading