Cleanup codebase to make it readable and usable#73
Open
adityasoni9998 wants to merge 2 commits intomajor-updatefrom
Open
Cleanup codebase to make it readable and usable#73adityasoni9998 wants to merge 2 commits intomajor-updatefrom
adityasoni9998 wants to merge 2 commits intomajor-updatefrom
Conversation
|
Hi Aditya, thanks for the cleanup PR — this seems super helpful. Some of the issues you fixed (especially the masking logic and the length-based loss masking) might explain why my earlier ablations on the I’m happy to help with the TODO you mentioned — e.g. doing an end-to-end validation by training a 4B Instruct model using this branch and checking whether rewards improve as expected. Let me know if the cleanup branch reflects the intended setup for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71 (mostly, but not fully)
Summary of changes made:
This code is tested by training the 1.7B RL'ed LLM ckpt for a few more steps -- it runs out-of-the-box, and the reward is similar/close to where it plateaued. But empirical end-to-end validation by training some base LLM and checking rewards going up or not is a TODO task.
TODOs/Questions: