chore: improve accessibility and security#707
chore: improve accessibility and security#707dipanshurdev wants to merge 1 commit intoOpenCut-app:mainfrom
Conversation
- Update roadmap description date from July 14, 2025 to February 2026 - Improve landing page hero image alt text for better a11y - Add noreferrer to external links for security best practice
|
@dipanshurdev is attempting to deploy a commit to the OpenCut OSS Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for appcut pending review.Visit the deploys page to approve it
|
📝 WalkthroughWalkthroughThree minor updates across the web application: enhanced link security attribute, updated metadata timestamp, and improved image accessibility text. All changes are cosmetic with no functional impact. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/src/app/privacy/page.tsx (1)
166-175:⚠️ Potential issue | 🟡 Minor
noreferreradded only to the Databuddy link — othertarget="_blank"links in this file are inconsistent.The Databuddy link now has
rel="noopener noreferrer", but the Better Auth link (Line 120), GitHub link (Line 238), GitHub issues link (Line 255), and X/Twitter link (Line 271) still use onlyrel="noopener". Ifnoreferreris the desired security posture, apply it consistently to all external links.Proposed fix
<a href="https://www.better-auth.com" target="_blank" - rel="noopener" + rel="noopener noreferrer" className="text-primary hover:underline" ><a href={SOCIAL_LINKS.github} target="_blank" - rel="noopener" + rel="noopener noreferrer" className="text-primary hover:underline" ><a href={`${SOCIAL_LINKS.github}/issues`} target="_blank" - rel="noopener" + rel="noopener noreferrer" className="text-primary hover:underline" ><a href={SOCIAL_LINKS.x} target="_blank" - rel="noopener" + rel="noopener noreferrer" className="text-primary hover:underline" >🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/app/privacy/page.tsx` around lines 166 - 175, The Databuddy anchor now uses rel="noopener noreferrer" while other external anchors with target="_blank" (the "Better Auth", "GitHub", "GitHub issues", and "X/Twitter" links) only use rel="noopener"; update those anchor elements so they consistently include rel="noopener noreferrer" to match the desired security posture, ensuring every <a> with target="_blank" in this component uses the same rel attributes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@apps/web/src/app/privacy/page.tsx`:
- Around line 166-175: The Databuddy anchor now uses rel="noopener noreferrer"
while other external anchors with target="_blank" (the "Better Auth", "GitHub",
"GitHub issues", and "X/Twitter" links) only use rel="noopener"; update those
anchor elements so they consistently include rel="noopener noreferrer" to match
the desired security posture, ensuring every <a> with target="_blank" in this
component uses the same rel attributes.
Accessibility & Security Improvements
Changes
noreferrerto external links (security best practice)Impact
Files Changed
Type: chore | Breaking: No
Summary by CodeRabbit
Release Notes