Skip to content

Handle 404 error differently in InstitutionAttributeAggregator #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phavekes wants to merge 2 commits into from
Closed

Handle 404 error differently in InstitutionAttributeAggregator #145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24d5417
Handle 404 error differently in InstitutionAttributeAggregator
phavekes Jan 7, 2026
0f3891c
Use HttpStatusCodeException
phavekes Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/main/java/aa/aggregators/institution/InstitutionAttributeAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import org.springframework.core.io.Resource;
import org.springframework.http.client.support.BasicAuthenticationInterceptor;
import org.springframework.util.CollectionUtils;
import org.springframework.web.client.HttpStatusCodeException;
import org.springframework.web.client.RestTemplate;

import java.util.ArrayList;
Expand Down Expand Up @@ -65,9 +66,17 @@ public List<UserAttribute> aggregate(List<UserAttribute> input, Map<String, List
Map<String, List<String>> body;
try {
body = restTemplate.getForEntity(url, Map.class).getBody();
} catch (RuntimeException e) {
} catch (HttpStatusCodeException e) {
String msg = String.format("InstitutionEndpoint %s configured for: %s, returned an error", institutionEndpoint, spEntityID);
LOG.error(msg, e);
if (e.getStatusCode().value() == 404) {
LOG.info(msg + " 404 Not Found");
} else {
LOG.error(msg, e);
}
return errorResponse(input);
} catch (RuntimeException e) {
// Voor netwerkfouten of andere runtime issues
LOG.error("System error calling InstitutionEndpoint", e);
return errorResponse(input);
}

Expand Down